[Php84] Skip variable extraction with return early on ForeachToArrayAllRector (#7591)

Author: samsonasik

rules-tests/Php84/Rector/Foreach_/ForeachToArrayAllRector/Fixture/skip_on_variable_extract.php.inc

@@ -0,0 +1,16 @@
+<?php
+
+namespace Rector\Tests\Php84\Rector\Foreach_\ForeachToArrayAllRector\Fixture;
+
+class SkipOnVariableExtract
+{
+  private function allDependencyHasType(array $dependencies, string $type): bool {
+    foreach ($dependencies as ['type' => $currentType]) {
+      if ($currentType !== $type) {
+        return false;
+      }
+    }
+
+    return true;
+  }
+}

rules/Php84/Rector/Foreach_/ForeachToArrayAllRector.php

@@ -276,6 +276,10 @@ private function isValidEarlyReturnForeachStructure(Foreach_ $foreach): bool
             return false;
         }
 
+        if (! $foreach->valueVar instanceof Variable) {
+            return false;
+        }
+
         $type = $this->nodeTypeResolver->getNativeType($foreach->expr);
 
         return $type->isArray()