[DeadCode] Skip next assign expr has side effect inside try {} on RemoveDoubleAssignRector (#7775)

* [DeadCode] Add test for RemoveDoubleAssignRector with reset before throwing assignment

Reproduces rectorphp/rector#9569

* rename fixture

* [DeadCode] Skip has side effect inside try {} on RemoveDoubleAssignRector

---------

Co-authored-by: Jan Tojnar <[email protected]>

Author: samsonasik

rules-tests/DeadCode/Rector/Assign/RemoveDoubleAssignRector/Fixture/skip_reset_before_throwing_assign.php.inc

@@ -0,0 +1,24 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Assign\RemoveDoubleAssignRector\Fixture;
+
+/** @throws \Exception */
+function get_body(): string {
+    static $i = 0;
+
+    var_dump($i);
+
+    return $i++ === 0 ? "foo" : throw new \Exception("Failed to get body");
+}
+
+foreach ([1, 2, 3] as $value) {
+    try {
+        $body = null;
+        $body = get_body();
+        var_dump($body);
+    } catch (\Exception) {
+        var_dump($body);
+    }
+
+}
+?>

rules/DeadCode/Rector/Assign/RemoveDoubleAssignRector.php

@@ -10,6 +10,7 @@
 use PhpParser\Node\Expr\StaticPropertyFetch;
 use PhpParser\Node\Expr\Variable;
 use PhpParser\Node\Stmt\Expression;
+use PhpParser\Node\Stmt\TryCatch;
 use Rector\DeadCode\SideEffect\SideEffectNodeDetector;
 use Rector\PhpParser\Enum\NodeGroup;
 use Rector\PhpParser\Node\BetterNodeFinder;
@@ -110,6 +111,11 @@ public function refactor(Node $node): ?Node
                 continue;
             }
 
+            // side effect may throw exception, and may be handled by catch block
+            if ($node instanceof TryCatch && $this->sideEffectNodeDetector->detectCallExpr($nextAssign->expr)) {
+                continue;
+            }
+
             // remove current Stmt if will be overridden in next stmt
             unset($node->stmts[$key]);