Skip to content

Commit 760eb16

Browse files
authored
make resolveClassReflection non-nullable as always passed a node (#7833)
1 parent 2fa9dda commit 760eb16

File tree

2 files changed

+1
-9
lines changed

2 files changed

+1
-9
lines changed

rules/TypeDeclaration/Rector/Property/TypedPropertyFromStrictConstructorRector.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -187,10 +187,6 @@ private function shouldSkipPropertyType(Type $propertyType): bool
187187

188188
private function hasSomeUntypedProperties(Class_ $class): bool
189189
{
190-
if ($class->getProperties() === []) {
191-
return false;
192-
}
193-
194190
foreach ($class->getProperties() as $property) {
195191
if ($property->type instanceof Node) {
196192
continue;

src/Reflection/ReflectionResolver.php

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -65,12 +65,8 @@ public function resolveClassAndAnonymousClass(ClassLike $classLike): ClassReflec
6565
return $this->reflectionProvider->getClass($className);
6666
}
6767

68-
public function resolveClassReflection(?Node $node): ?ClassReflection
68+
public function resolveClassReflection(Node $node): ?ClassReflection
6969
{
70-
if (! $node instanceof Node) {
71-
return null;
72-
}
73-
7470
$scope = $node->getAttribute(AttributeKey::SCOPE);
7571
if (! $scope instanceof Scope) {
7672
return null;

0 commit comments

Comments
 (0)