[DeadCode] Skip private promoted property on RemoveParentDelegatingConstructorRector (#7817)

Author: samsonasik

rules-tests/DeadCode/Rector/ClassMethod/RemoveParentDelegatingConstructorRector/Fixture/skip_private_property_promotion.php.inc

@@ -0,0 +1,18 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\ClassMethod\RemoveParentDelegatingConstructorRector\Fixture;
+
+use Rector\Tests\DeadCode\Rector\ClassMethod\RemoveParentDelegatingConstructorRector\Source\SomeParentWithPrivatePropertyPromotion;
+
+class SkipPrivatePropertyPromotion extends SomeParentWithPrivatePropertyPromotion
+{
+    public function __construct(private \DateTime $d)
+    {
+        parent::__construct($d);
+    }
+
+    public function run()
+    {
+        return $this->d->format('Y-m-d');
+    }
+}

rules-tests/DeadCode/Rector/ClassMethod/RemoveParentDelegatingConstructorRector/Source/SomeParentWithPrivatePropertyPromotion.php

@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\DeadCode\Rector\ClassMethod\RemoveParentDelegatingConstructorRector\Source;
+
+class SomeParentWithPrivatePropertyPromotion
+{
+    public function __construct(private \DateTime $d)
+    {
+    }
+}

rules/DeadCode/Rector/ClassMethod/RemoveParentDelegatingConstructorRector.php

@@ -220,6 +220,10 @@ private function areConstructorAndParentParameterTypesMatching(
         ExtendedMethodReflection $extendedMethodReflection
     ): bool {
         foreach ($classMethod->getParams() as $position => $param) {
+            if ($param->isPromoted() && $param->isPrivate()) {
+                return false;
+            }
+
             $parameterType = $param->type;
 
             // no type override