avoid spl_object_id() if no change in AbstractRector (#7653)

Author: TomasVotruba

src/Application/NodeAttributeReIndexer.php

@@ -25,21 +25,6 @@
 
 final class NodeAttributeReIndexer
 {
-    private static function reIndexStmtsKeys(Node $node): ?Node
-    {
-        if (! $node instanceof StmtsAwareInterface && ! $node instanceof ClassLike && ! $node instanceof Declare_ && ! $node instanceof Block) {
-            return null;
-        }
-
-        if ($node->stmts === null) {
-            return null;
-        }
-
-        $node->stmts = array_values($node->stmts);
-
-        return $node;
-    }
-
     public static function reIndexNodeAttributes(Node $node): ?Node
     {
         self::reIndexStmtsKeys($node);
@@ -78,4 +63,19 @@ public static function reIndexNodeAttributes(Node $node): ?Node
 
         return null;
     }
+
+    private static function reIndexStmtsKeys(Node $node): ?Node
+    {
+        if (! $node instanceof StmtsAwareInterface && ! $node instanceof ClassLike && ! $node instanceof Declare_ && ! $node instanceof Block) {
+            return null;
+        }
+
+        if ($node->stmts === null) {
+            return null;
+        }
+
+        $node->stmts = array_values($node->stmts);
+
+        return $node;
+    }
 }

src/Rector/AbstractRector.php

@@ -196,6 +196,11 @@ final public function leaveNode(Node $node): array|int|Node|null
             return null;
         }
 
+        // nothing to change here
+        if ($this->toBeRemovedNodeId === null && $this->nodesToReturn === []) {
+            return null;
+        }
+
         $objectId = spl_object_id($node);
         if ($this->toBeRemovedNodeId === $objectId) {
             $this->toBeRemovedNodeId = null;