remove arg positoin from AddClosureParamTypeFromArg, to ease configuration (#6260)

* remove arg positoin from AddClosureParamTypeFromArg, to ease configuration

* fixup! remove arg positoin from AddClosureParamTypeFromArg, to ease configuration

Author: TomasVotruba

rules-tests/TypeDeclaration/Rector/FunctionLike/AddClosureParamTypeFromArgRector/config/configured_rule.php

@@ -11,7 +11,7 @@
 return static function (RectorConfig $rectorConfig): void {
     $rectorConfig
         ->ruleWithConfiguration(AddClosureParamTypeFromArgRector::class, [
-            new AddClosureParamTypeFromArg(SimpleContainer::class, 'someCall', 1, 0, 0),
+            new AddClosureParamTypeFromArg(SimpleContainer::class, 'someCall', 1, 0),
         ]);
 
     $rectorConfig->phpVersion(PhpVersionFeature::MIXED_TYPE);

rules/TypeDeclaration/Rector/FunctionLike/AddClosureParamTypeFromArgRector.php

@@ -35,6 +35,11 @@
  */
 final class AddClosureParamTypeFromArgRector extends AbstractRector implements ConfigurableRectorInterface
 {
+    /**
+     * @var int
+     */
+    private const DEFAULT_CLOSURE_ARG_POSITION = 0;
+
     /**
      * @var AddClosureParamTypeFromArg[]
      */
@@ -61,7 +66,7 @@ public function getRuleDefinition(): RuleDefinition
 $app->extend(SomeClass::class, function (SomeClass $parameter) {});
 CODE_SAMPLE
                 ,
-                [new AddClosureParamTypeFromArg('Container', 'extend', 1, 0, 0)]
+                [new AddClosureParamTypeFromArg('Container', 'extend', 1, 0)]
             ),
         ]);
     }
@@ -135,7 +140,7 @@ private function processCallLike(
             return null;
         }
 
-        $callLikeArg = $callLike->getArgs()[$addClosureParamTypeFromArg->getFromArgPosition()] ?? null;
+        $callLikeArg = $callLike->getArgs()[self::DEFAULT_CLOSURE_ARG_POSITION] ?? null;
         if (! $callLikeArg instanceof Arg) {
             return null;
         }

rules/TypeDeclaration/ValueObject/AddClosureParamTypeFromArg.php

@@ -12,14 +12,12 @@
     /**
      * @param int<0, max> $callLikePosition
      * @param int<0, max> $functionLikePosition
-     * @param int<0, max> $fromArgPosition
      */
     public function __construct(
         private string $className,
         private string $methodName,
         private int $callLikePosition,
         private int $functionLikePosition,
-        private int $fromArgPosition,
     ) {
         RectorAssert::className($className);
     }
@@ -49,12 +47,4 @@ public function getFunctionLikePosition(): int
     {
         return $this->functionLikePosition;
     }
-
-    /**
-     * @return int<0, max>
-     */
-    public function getFromArgPosition(): int
-    {
-        return $this->fromArgPosition;
-    }
 }