tv skip ctor attribute (#7812)

* cs

* skip marker attribute in RemoveUnusedConstructorParamRector

Author: TomasVotruba

rules-tests/DeadCode/Rector/ClassMethod/RemoveUnusedConstructorParamRector/Fixture/skip_attribute_marker.php.inc

@@ -0,0 +1,16 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\ClassMethod\RemoveUnusedConstructorParamRector\Fixture;
+
+use Rector\Contract\Rector\RectorInterface;
+
+#[\Attribute]
+final class SkipAttributeMarker
+{
+    /**
+     * @param RectorInterface $someClass
+     */
+    public function __construct(string $someClass)
+    {
+    }
+}

rules/DeadCode/Rector/ClassMethod/RemoveUnusedConstructorParamRector.php

@@ -4,6 +4,7 @@
 
 namespace Rector\DeadCode\Rector\ClassMethod;
 
+use PhpParser\Comment\Doc;
 use PhpParser\Node;
 use PhpParser\Node\Stmt\Class_;
 use PhpParser\Node\Stmt\ClassMethod;
@@ -91,11 +92,17 @@ public function refactor(Node $node): ?Node
 
         $interfaces = $classReflection->getInterfaces();
         foreach ($interfaces as $interface) {
+            // parameters are contract required → skip
             if ($interface->hasNativeMethod(MethodName::CONSTRUCT)) {
                 return null;
             }
         }
 
+        // attributes can be used as markers
+        if ($classReflection->isAttributeClass() && $constructorClassMethod->getDocComment() instanceof Doc) {
+            return null;
+        }
+
         $changedConstructorClassMethod = $this->classMethodParamRemover->processRemoveParams($constructorClassMethod);
         if (! $changedConstructorClassMethod instanceof ClassMethod) {
             return null;

tests/Issues/IssuePropertyPromoRemoveDelegatingParent/config/configured_rule.php

@@ -8,4 +8,4 @@
     ->withRules([
         ClassPropertyAssignToConstructorPromotionRector::class,
         RemoveParentDelegatingConstructorRector::class,
-    ]);
+    ]);