Add check for append in foreach items assignment (#7815)

* Add check for append in foreach items assignment

* Add test fixture for skipping assignment before conditional foreach

Author: solverat

rules-tests/CodeQuality/Rector/Foreach_/ForeachItemsAssignToEmptyArrayToAssignRector/Fixture/skip_assigned_before_in_conditional_foreach.php.inc

@@ -0,0 +1,26 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\Foreach_\ForeachItemsAssignToEmptyArrayToAssignRector\Fixture;
+
+final class SkipAssignedBeforeInConditionalForeach
+{
+    public function run($data)
+    {
+        $list = [];
+        $groupList = [];
+
+        foreach ($data->getItems() as $item) {
+            if ($item->hasGroup()) {
+                $groupList[] = ['id' => $item->getGroupId()];
+            } else {
+                $list[] = ['id' => $item->getId()];
+            }
+        }
+
+        foreach ($groupList as $group) {
+            $list[] = $group;
+        }
+
+        return $list;
+    }
+}

rules/CodeQuality/Rector/Foreach_/ForeachItemsAssignToEmptyArrayToAssignRector.php

@@ -104,6 +104,10 @@ public function refactor(Node $node): ?Node
             }
 
             if ($this->shouldSkip($stmt, $emptyArrayVariables)) {
+                if ($this->isAppend($stmt, $emptyArrayVariables)) {
+                    return null;
+                }
+                
                 continue;
             }