extract NodeTraverser from vendor, make it immutable and make it part of rector-src to avoid patching

Author: TomasVotruba

scripts/copy-and-create-immuatable-node-visitor.php

@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+require __DIR__ . '/../vendor/autoload.php';
+
+
+// 1. copy file from vendor
+// load file contents from venodr
+
+// modify clas name + namespace
+
+// add it here as ImmutableNodeTraverser.php
+
+\Nette\Utils\FileSystem::copy(__DIR__ . '/../vendor/nikic/php-parser/lib/PhpParser/NodeTraverser.php', __DIR__ . '/../src/PhpParser/NodeTraverser/ImmutableNodeTraverser.php');

src/PhpParser/NodeTraverser/RectorNodeTraverser.php

@@ -11,6 +11,7 @@
 use Rector\Configuration\ConfigurationRuleFilter;
 use Rector\Contract\Rector\RectorInterface;
 use Rector\VersionBonding\PhpVersionedFilter;
+use Webmozart\Assert\Assert;
 
 /**
  * @see \Rector\Tests\PhpParser\NodeTraverser\RectorNodeTraverserTest
@@ -68,10 +69,12 @@ public function refreshPhpRectors(array $rectors): void
     public function getVisitorsForNode(Node $node): array
     {
         $nodeClass = $node::class;
+
         if (! isset($this->visitorsPerNodeClass[$nodeClass])) {
             $this->visitorsPerNodeClass[$nodeClass] = [];
             foreach ($this->visitors as $visitor) {
-                assert($visitor instanceof RectorInterface);
+                // already checked in prepare visitors method
+                /** @var RectorInterface $visitor */
                 foreach ($visitor->getNodeTypes() as $nodeType) {
                     if (is_a($nodeClass, $nodeType, true)) {
                         $this->visitorsPerNodeClass[$nodeClass][] = $visitor;
@@ -85,10 +88,9 @@ public function getVisitorsForNode(Node $node): array
     }
 
     /**
-     * This must happen after $this->configuration is set after ProcessCommand::execute() is run,
-     * otherwise we get default false positives.
+     * This must happen after $this->configuration is set after ProcessCommand::execute() is run, otherwise we get default false positives.
      *
-     * This hack should be removed after https://github.com/rectorphp/rector/issues/5584 is resolved
+     * This should be removed after https://github.com/rectorphp/rector/issues/5584 is resolved
      */
     private function prepareNodeVisitors(): void
     {