refactor: make DeclareStrictTypesRector safe and add to ruleset

Author: calebdw

composer.json

@@ -99,6 +99,7 @@
             "tests/debug_functions.php",
             "rules-tests/Transform/Rector/FuncCall/FuncCallToMethodCallRector/Source/some_view_function.php",
             "rules-tests/TypeDeclaration/Rector/ClassMethod/ParamTypeByMethodCallTypeRector/Source/FunctionTyped.php",
+            "rules-tests/TypeDeclaration/Rector/StmtsAwareInterface/DeclareStrictTypesRector/Source/functions.php",
             "rules-tests/Php70/Rector/ClassMethod/Php4ConstructorRector/Source/ParentClass.php",
             "rules-tests/CodingStyle/Rector/Closure/StaticClosureRector/Source/functions.php"
         ]

e2e/parallel with space/src/Test.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 class Test
 {
 }

rules-tests/TypeDeclaration/Rector/StmtsAwareInterface/DeclareStrictTypesRector/Fixture/arrow_function_return.php.inc

@@ -0,0 +1,23 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector\Fixture;
+
+$arrow = fn (): int => 42;
+
+$arrowWithParam = fn (int $x): int => $x + 1;
+
+$arrowString = fn (): string => 'hello';
+
+?>
+-----
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector\Fixture;
+
+$arrow = fn (): int => 42;
+
+$arrowWithParam = fn (int $x): int => $x + 1;
+
+$arrowString = fn (): string => 'hello';

rules-tests/TypeDeclaration/Rector/StmtsAwareInterface/DeclareStrictTypesRector/Fixture/closure_return.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector\Fixture;
+
+$closure = function (): int {
+    return 42;
+};
+
+$closureWithParam = function (int $x): int {
+    return $x + 1;
+};
+
+?>
+-----
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector\Fixture;
+
+$closure = function (): int {
+    return 42;
+};
+
+$closureWithParam = function (int $x): int {
+    return $x + 1;
+};

rules-tests/TypeDeclaration/Rector/StmtsAwareInterface/DeclareStrictTypesRector/Fixture/constructor_calls.php.inc

@@ -0,0 +1,19 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector\Fixture;
+
+use Rector\Tests\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector\Source\TypedClass;
+
+new TypedClass('John', 25);
+
+?>
+-----
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector\Fixture;
+
+use Rector\Tests\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector\Source\TypedClass;
+
+new TypedClass('John', 25);

rules-tests/TypeDeclaration/Rector/StmtsAwareInterface/DeclareStrictTypesRector/Fixture/explicit_cast.php.inc

@@ -0,0 +1,25 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector\Fixture;
+
+use function Rector\Tests\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector\Source\acceptsInt;
+
+function callWithCast(): void
+{
+    acceptsInt((int) '123');
+}
+
+?>
+-----
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector\Fixture;
+
+use function Rector\Tests\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector\Source\acceptsInt;
+
+function callWithCast(): void
+{
+    acceptsInt((int) '123');
+}

rules-tests/TypeDeclaration/Rector/StmtsAwareInterface/DeclareStrictTypesRector/Fixture/first_class_callable.php.inc

@@ -0,0 +1,19 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector\Fixture;
+
+$fn = strlen(...);
+
+$upperFn = strtoupper(...);
+
+?>
+-----
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector\Fixture;
+
+$fn = strlen(...);
+
+$upperFn = strtoupper(...);

rules-tests/TypeDeclaration/Rector/StmtsAwareInterface/DeclareStrictTypesRector/Fixture/int_to_float_parameter.php.inc

@@ -0,0 +1,19 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector\Fixture;
+
+use function Rector\Tests\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector\Source\acceptsFloat;
+
+acceptsFloat(123);
+
+?>
+-----
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector\Fixture;
+
+use function Rector\Tests\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector\Source\acceptsFloat;
+
+acceptsFloat(123);

rules-tests/TypeDeclaration/Rector/StmtsAwareInterface/DeclareStrictTypesRector/Fixture/method_calls.php.inc

@@ -0,0 +1,25 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector\Fixture;
+
+use Rector\Tests\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector\Source\TypedClass;
+
+function useMethodCalls(TypedClass $obj): void
+{
+    $obj->add(1, 2);
+}
+
+?>
+-----
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector\Fixture;
+
+use Rector\Tests\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector\Source\TypedClass;
+
+function useMethodCalls(TypedClass $obj): void
+{
+    $obj->add(1, 2);
+}

rules-tests/TypeDeclaration/Rector/StmtsAwareInterface/DeclareStrictTypesRector/Fixture/multiple_declare.php.inc

@@ -2,15 +2,6 @@
 
 namespace Rector\Tests\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector\Fixture;
 
-$count = 0;
-function example() {
-  global $count;
-  $count++;
-  echo "$count instructions executed<br>";
-}
-
-register_tick_function('example');
-
 declare(ticks=1) {
   $cars = ["Ford", "Volvo", "BMW"];
   foreach($cars as $car) {
@@ -26,15 +17,6 @@ declare(strict_types=1);
 
 namespace Rector\Tests\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector\Fixture;
 
-$count = 0;
-function example() {
-  global $count;
-  $count++;
-  echo "$count instructions executed<br>";
-}
-
-register_tick_function('example');
-
 declare(ticks=1) {
   $cars = ["Ford", "Volvo", "BMW"];
   foreach($cars as $car) {