[SYMFONY 3.2] replace Cookie argument values with constants (#817)

Author: JohJohan

config/sets/symfony/symfony3/symfony32.php

@@ -2,8 +2,11 @@
 
 declare(strict_types=1);
 
+use Rector\Arguments\Rector\ClassMethod\ReplaceArgumentDefaultValueRector;
+use Rector\Arguments\ValueObject\ReplaceArgumentDefaultValue;
 use Rector\Config\RectorConfig;
 
 return static function (RectorConfig $rectorConfig): void {
     $rectorConfig->import(__DIR__ . '/symfony32/symfony32-dependency-injection.php');
+    $rectorConfig->import(__DIR__ . '/symfony32/symfony32-http-foundation.php');
 };

config/sets/symfony/symfony3/symfony32/symfony32-http-foundation.php

@@ -0,0 +1,27 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Arguments\Rector\ClassMethod\ReplaceArgumentDefaultValueRector;
+use Rector\Arguments\ValueObject\ReplaceArgumentDefaultValue;
+use Rector\Config\RectorConfig;
+
+return static function (RectorConfig $rectorConfig): void {
+
+    $rectorConfig->ruleWithConfiguration(ReplaceArgumentDefaultValueRector::class, [
+        new ReplaceArgumentDefaultValue(
+            'Symfony\Component\HttpFoundation\Cookie',
+            '__construct',
+            8,
+            'lax',
+            'Symfony\Component\HttpFoundation\Cookie::SAMESITE_LAX'
+        ),
+        new ReplaceArgumentDefaultValue(
+            'Symfony\Component\HttpFoundation\Cookie',
+            '__construct',
+            8,
+            'strict',
+            'Symfony\Component\HttpFoundation\Cookie::SAMESITE_STRICT'
+        ),
+    ]);
+};

src/Set/SetProvider/Symfony3SetProvider.php

@@ -136,6 +136,13 @@ public function provide(): array
                 __DIR__ . '/../../../config/sets/symfony/symfony3/symfony32/symfony32-dependency-injection.php'
             ),
 
+            new ComposerTriggeredSet(
+                SetGroup::SYMFONY,
+                'symfony/http-foundation',
+                '3.2',
+                __DIR__ . '/../../../config/sets/symfony/symfony3/symfony32/symfony32-http-foundation.php'
+            ),
+
             new ComposerTriggeredSet(
                 SetGroup::SYMFONY,
                 'symfony/symfony',

tests/Set/Symfony32/Fixture/replace_new_cookie_parameter_value.php.inc

@@ -0,0 +1,32 @@
+<?php
+
+namespace Rector\Symfony\Tests\Set\Symfony32\Fixture;
+
+use Symfony\Component\HttpFoundation\Cookie;
+
+class ReplaceNewCookieParameterValue
+{
+    public function run()
+    {
+        return new Cookie('name', 'value', 0, '/', null, false, true, false, 'lax');
+    }
+}
+
+?>
+
+-----
+<?php
+
+namespace Rector\Symfony\Tests\Set\Symfony32\Fixture;
+
+use Symfony\Component\HttpFoundation\Cookie;
+
+class ReplaceNewCookieParameterValue
+{
+    public function run()
+    {
+        return new Cookie('name', 'value', 0, '/', null, false, true, false, \Symfony\Component\HttpFoundation\Cookie::SAMESITE_LAX);
+    }
+}
+
+?>

tests/Set/Symfony32/Symfony32Test.php

@@ -0,0 +1,28 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Symfony\Tests\Set\Symfony32;
+
+use Iterator;
+use PHPUnit\Framework\Attributes\DataProvider;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+
+final class Symfony32Test extends AbstractRectorTestCase
+{
+    #[DataProvider('provideData')]
+    public function test(string $filePath): void
+    {
+        $this->doTestFile($filePath);
+    }
+
+    public static function provideData(): Iterator
+    {
+        return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/symfony32.php';
+    }
+}

tests/Set/Symfony32/config/symfony32.php

@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\Symfony\Set\SymfonySetList;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->sets([SymfonySetList::SYMFONY_32]);
+};