[CodeQuality] Skip parent method exists on ControllerMethodInjectionToConstructorRector (#889)

* [CodeQuality] Skip parent method exists on ControllerMethodInjectionToConstructorRector

* fix

* also skip abstract class

Author: samsonasik

rules-tests/CodeQuality/Rector/Class_/ControllerMethodInjectionToConstructorRector/Fixture/skip_abstract_class.php.inc

@@ -0,0 +1,20 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Symfony\Tests\CodeQuality\Rector\Class_\ControllerMethodInjectionToConstructorRector\Fixture;
+
+use Psr\Log\LoggerInterface;
+use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
+use Symfony\Component\Routing\Annotation\Route;
+
+abstract class SkipAbstractClass extends AbstractController
+{
+    #[Route('/some-action', name: 'some_action')]
+    public function someAction(LoggerInterface $logger)
+    {
+        $someClosure = function () use ($logger) {
+            $logger->log('level', 'value');
+        };
+    }
+}

rules-tests/CodeQuality/Rector/Class_/ControllerMethodInjectionToConstructorRector/Fixture/skip_parent_method_exists.php.inc

@@ -0,0 +1,26 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Symfony\Tests\CodeQuality\Rector\Class_\ControllerMethodInjectionToConstructorRector\Fixture;
+
+use Psr\Log\LoggerInterface;
+use Rector\Symfony\Tests\CodeQuality\Rector\Class_\ControllerMethodInjectionToConstructorRector\Source\IntermediateController;
+use Symfony\Component\Routing\Annotation\Route;
+
+final class SkipParentMethodExists extends IntermediateController
+{
+    public function __construct()
+    {
+    }
+
+    #[Route('/some-action', name: 'some_action')]
+    public function someAction(LoggerInterface $logger)
+    {
+        $someClosure = function () use ($logger) {
+            $logger->log('level', 'value');
+        };
+    }
+}
+
+?>

rules-tests/CodeQuality/Rector/Class_/ControllerMethodInjectionToConstructorRector/Source/IntermediateController.php

@@ -0,0 +1,18 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Symfony\Tests\CodeQuality\Rector\Class_\ControllerMethodInjectionToConstructorRector\Source;
+
+use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
+use Psr\Log\LoggerInterface;
+use Symfony\Component\Routing\Annotation\Route;
+
+class IntermediateController extends AbstractController
+{
+    #[Route('/some-action', name: 'some_action')]
+    public function someAction(LoggerInterface $logger)
+    {
+        // to be overridden
+    }
+}

rules/CodeQuality/Rector/Class_/ControllerMethodInjectionToConstructorRector.php

@@ -25,6 +25,7 @@
 use Rector\Symfony\Enum\SymfonyClass;
 use Rector\Symfony\TypeAnalyzer\ControllerAnalyzer;
 use Rector\ValueObject\MethodName;
+use Rector\VendorLocker\ParentClassMethodTypeOverrideGuard;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 
@@ -45,6 +46,7 @@ public function __construct(
         private readonly StaticTypeMapper $staticTypeMapper,
         private readonly AttributeFinder $attributeFinder,
         private readonly ValueResolver $valueResolver,
+        private readonly ParentClassMethodTypeOverrideGuard $parentClassMethodOverrideGuard
     ) {
     }
 
@@ -113,6 +115,10 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
+        if ($node->isAbstract()) {
+            return null;
+        }
+
         $propertyMetadatas = [];
 
         foreach ($node->getMethods() as $classMethod) {
@@ -218,7 +224,13 @@ private function shouldSkipClassMethod(ClassMethod $classMethod): bool
             return true;
         }
 
-        return ! $this->controllerMethodAnalyzer->isAction($classMethod);
+        if (! $this->controllerMethodAnalyzer->isAction($classMethod)) {
+            return true;
+        }
+
+        return $this->parentClassMethodOverrideGuard->hasParentClassMethod(
+            $classMethod
+        );
     }
 
     /**