Skip to content

Commit 4026ff1

Browse files
committed
Updated Rector to commit 2adeacc410de9304137574d2e80cf97c9f67dfa5
rectorphp/rector-src@2adeacc [Performance]EarlyReturn] Reduce repetitive findFirst() on IfAndAnalyzer::isIfStmtExprUsedInNextReturn() (#5709)
1 parent 8201d0f commit 4026ff1

File tree

2 files changed

+9
-10
lines changed

2 files changed

+9
-10
lines changed

rules/EarlyReturn/NodeAnalyzer/IfAndAnalyzer.php

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -42,14 +42,13 @@ public function isIfStmtExprUsedInNextReturn(If_ $if, Return_ $return) : bool
4242
return \false;
4343
}
4444
$ifExprs = $this->betterNodeFinder->findInstanceOf($if->stmts, Expr::class);
45-
foreach ($ifExprs as $ifExpr) {
46-
$isExprFoundInReturn = (bool) $this->betterNodeFinder->findFirst($return->expr, function (Node $node) use($ifExpr) : bool {
47-
return $this->nodeComparator->areNodesEqual($node, $ifExpr);
48-
});
49-
if ($isExprFoundInReturn) {
50-
return \true;
45+
return (bool) $this->betterNodeFinder->findFirst($return->expr, function (Node $node) use($ifExprs) : bool {
46+
foreach ($ifExprs as $ifExpr) {
47+
if ($this->nodeComparator->areNodesEqual($node, $ifExpr)) {
48+
return \true;
49+
}
5150
}
52-
}
53-
return \false;
51+
return \false;
52+
});
5453
}
5554
}

src/Application/VersionResolver.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,12 @@ final class VersionResolver
1919
* @api
2020
* @var string
2121
*/
22-
public const PACKAGE_VERSION = '57894303baab2e24a24387b48c5e94963e78ad26';
22+
public const PACKAGE_VERSION = '2adeacc410de9304137574d2e80cf97c9f67dfa5';
2323
/**
2424
* @api
2525
* @var string
2626
*/
27-
public const RELEASE_DATE = '2024-03-11 00:09:51';
27+
public const RELEASE_DATE = '2024-03-11 09:10:24';
2828
/**
2929
* @var int
3030
*/

0 commit comments

Comments
 (0)