RemoveParamRector

[brandonkelly]

We have a couple methods in Craft 4 that have dropped an argument, and it would be great if there was a way to automatically remove any code calling them via Rector. For example:

$services->set(RemoveParamRector::class)
    ->configure([
        new RemoveParam('MyClass', 'methodName', 2),
    ]);

Which would cause the following change:

 /** @var MyClass $obj */
-$obj->methodName($arg1, $arg2, $arg3, $arg4);
+$obj->methodName($arg1, $arg2, $arg4);

[TomasVotruba]

Added in https://github.com/rectorphp/rector-src/pull/1906/files

[TomasVotruba]

Ah, it seem it's static call. This rule handles method call, based on the example 😄

[brandonkelly]

Ah whoops, I need both, but didn’t think about how the implementation would be different.

[TomasVotruba]

No troubles 👍
In php-parser, mostly any expression is different node:

• https://github.com/rectorphp/php-parser-nodes-docs#phpparsernodeexprmethodcall
• https://github.com/rectorphp/php-parser-nodes-docs#phpparsernodeexprstaticcall

I've added StaticCall support here: https://github.com/rectorphp/rector-src/pull/1916/files

[brandonkelly]

Amazing! Works like a charm now. Thanks so much!

[TomasVotruba]

You're welcome 👍