Cannot add a new node before current statement

[Mirko-Tebaldi]

Having this line of code

$year=date("Y",strtotime(mysql_result($result,0)));

I am actually moving out the internal func call to obtain this

$date_string = mysql_result($result,0);
$year=date("Y",strtotime( $date_string ));

Actualy rule code, after initial tests, is doing this

$current_line = $this->betterNodeFinder->resolveCurrentStatement($node);
// $current_line is 
// $year = \date("Y", \strtotime(\mysql_result($result, 0)));'

$arg_0 = $node->args[0];
$internal_func_call = $arg_0->value;

$new_argo_0 = new Variable('date_as_string');
$node->args[0] = $new_argo_0;
// Now node is
// \strtotime($date_as_string)

$date_str_variable = new Variable('date_as_string');
$new_assign_node = new Assign($date_str_variable, $internal_func_call);
// $new_assign_node is
// $date_as_string = \mysql_result($result, 0)

$this->nodesToAddCollector->addNodeBeforeNode(
    $new_assign_node,
    $this->betterNodeFinder->resolveCurrentStatement($node)
);

return $node;

But I got this error

Fatal error: Uncaught Error: Attempt to assign property "value" on null in ..\rules\ExtractMysqlResultFromStrtotime.php:92                                                                                            
Stack trace:                                                                                                                                                                                                                                  
#0 ..\vendor\rector\rector\src\Rector\AbstractRector.php(223): Rules\ExtractMysqlResultFromStrtotime->refactor(Object(PhpParser\Node\Expr\FuncCall))                                                                  
#1 ..\vendor\rector\rector\vendor\nikic\php-parser\lib\PhpParser\NodeTraverser.php(113): Rector\Core\Rector\AbstractRector->enterNode(Object(PhpParser\Node\Expr\FuncCall))                                           
#2 ..\vendor\rector\rector\vendor\nikic\php-parser\lib\PhpParser\NodeTraverser.php(196): PhpParser\NodeTraverser->traverseNode(Object(PhpParser\Node\Arg))                                                            
#3 ..\vendor\rector\rector\vendor\nikic\php-parser\lib\PhpParser\NodeTraverser.php(105): PhpParser\NodeTraverser->traverseArray(Array)                                                                                
#4 ..\vendor\rector\rector\vendor\nikic\php-parser\lib\PhpParser\NodeTraverser.php(133): PhpParser\NodeTraverser->traverseNode(Object(PhpParser\Node\Expr\FuncCall))                                                  
#5 ..\vendor\rector\rector\vendor\nikic\php-parser\lib\PhpParser\NodeTraverser.php(133): PhpParser\NodeTraverser->traverseNode(Object(PhpParser\Node\Expr\Assign))                                                    
#6 ..\vendor\rector\rector\vendor\nikic\php-parser\lib\PhpParser\NodeTraverser.php(196): PhpParser\NodeTraverser->traverseNode(Object(PhpParser\Node\Stmt\Expression))                                                
#7 ..\vendor\rector\rector\vendor\nikic\php-parser\lib\PhpParser\NodeTraverser.php(105): PhpParser\NodeTraverser->traverseArray(Array)                                                                                
#8 ..\vendor\rector\rector\vendor\nikic\php-parser\lib\PhpParser\NodeTraverser.php(196): PhpParser\NodeTraverser->traverseNode(Object(Rector\Core\PhpParser\Node\CustomNode\FileWithoutNamespace))                    
#9 ..\vendor\rector\rector\vendor\nikic\php-parser\lib\PhpParser\NodeTraverser.php(85): PhpParser\NodeTraverser->traverseArray(Array)                                                                                 
#10 ..\vendor\rector\rector\src\PhpParser\NodeTraverser\RectorNodeTraverser.php(42): PhpParser\NodeTraverser->traverse(Array)                                                                                         
#11 ..\vendor\rector\rector\src\Application\FileProcessor.php(60): Rector\Core\PhpParser\NodeTraverser\RectorNodeTraverser->traverse(Array)                                                                           
#12 ..\vendor\rector\rector\src\Application\FileProcessor\PhpFileProcessor.php(133): Rector\Core\Application\FileProcessor->refactor(Object(Rector\Core\ValueObject\Application\File), Object(Rector\Core\ValueObject\
Configuration))                                                                                                                                                                                                                               
#13 ..\vendor\rector\rector\src\Application\FileProcessor\PhpFileProcessor.php(101): Rector\Core\Application\FileProcessor\PhpFileProcessor->refactorNodesWithRectors(Object(Rector\Core\ValueObject\Application\File)
, Object(Rector\Core\ValueObject\Configuration))                                                                                                                                                                                              
#14 ..\vendor\rector\rector\src\Application\ApplicationFileProcessor.php(160): Rector\Core\Application\FileProcessor\PhpFileProcessor->process(Object(Rector\Core\ValueObject\Application\File), Object(Rector\Core\Va
lueObject\Configuration))                                                                                                                                                                                                                     
#15 ..\vendor\rector\rector\src\Application\ApplicationFileProcessor.php(133): Rector\Core\Application\ApplicationFileProcessor->processFiles(Array, Object(Rector\Core\ValueObject\Configuration))                   
#16 ..\vendor\rector\rector\src\Console\Command\ProcessCommand.php(118): Rector\Core\Application\ApplicationFileProcessor->run(Object(Rector\Core\ValueObject\Configuration), Object(RectorPrefix202211\Symfony\Compon
ent\Console\Input\ArgvInput))                                                                                                                                                                                                                 
#17 ..\vendor\rector\rector\vendor\symfony\console\Command\Command.php(307): Rector\Core\Console\Command\ProcessCommand->execute(Object(RectorPrefix202211\Symfony\Component\Console\Input\ArgvInput), Object(RectorPr
efix202211\Symfony\Component\Console\Output\ConsoleOutput))                                                                                                                                                                                   
#18 ..\vendor\rector\rector\vendor\symfony\console\Application.php(896): RectorPrefix202211\Symfony\Component\Console\Command\Command->run(Object(RectorPrefix202211\Symfony\Component\Console\Input\ArgvInput), Objec
t(RectorPrefix202211\Symfony\Component\Console\Output\ConsoleOutput))                                                                                                                                                                         
#19 ..\vendor\rector\rector\vendor\symfony\console\Application.php(312): RectorPrefix202211\Symfony\Component\Console\Application->doRunCommand(Object(Rector\Core\Console\Command\ProcessCommand), Object(RectorPrefi
x202211\Symfony\Component\Console\Input\ArgvInput), Object(RectorPrefix202211\Symfony\Component\Console\Output\ConsoleOutput))                                                                                                                
#20 ..\vendor\rector\rector\src\Console\ConsoleApplication.php(49): RectorPrefix202211\Symfony\Component\Console\Application->doRun(Object(RectorPrefix202211\Symfony\Component\Console\Input\ArgvInput), Object(Recto
rPrefix202211\Symfony\Component\Console\Output\ConsoleOutput))                                                                                                                                                                                
#21 ..\vendor\rector\rector\vendor\symfony\console\Application.php(208): Rector\Core\Console\ConsoleApplication->doRun(Object(RectorPrefix202211\Symfony\Component\Console\Input\ArgvInput), Object(RectorPrefix202211
\Symfony\Component\Console\Output\ConsoleOutput))                                                                                                                                                                                             
#22 ..\vendor\rector\rector\bin\rector.php(128): RectorPrefix202211\Symfony\Component\Console\Application->run()                                                                                                      
#23 ..\vendor\rector\rector\bin\rector(5): require_once('C:\\laragon\\www\\...')                                                                                                                                      
#24 ..\vendor\bin\rector(120): include('C:\\laragon\\www\\...')                                                                                                                                                       
#25 {main}                                                                                                                                                                                                                                    
  thrown in ..\rules\ExtractMysqlResultFromStrtotime.php on line 92                                                                                                                                                   

[TomasVotruba]

Hi, if you want to replace 1 node with 2, just return array of 2 stmts:

return [$firstStmt, $secondStmt];

That will update the node tree with these 2 new nodes.

[Mirko-Tebaldi]

I cannot do this because I am not able to replace the node I am refactoring into its whole current line.
This is due to the fact I could have potentially a lot of nested func call, or other operations in the same line.

For example

$anno_max= date("Y",strtotime(mysql_result($result,0)));

I need to return the new line before current line AND return the modified node

I don't understand the source of the error I posted

Anyway if I return 2 nodes I got this error

Fatal error: Uncaught TypeError: Rules\ExtractMysqlResultFromStrtotime::refactor(): Return value must be of type ?PhpParser\Node, array returned in...\rules\ExtractMysqlResultFromStrtotime.php:113

[samsonasik]

The error already show it, you need to change the return type:

public function refactor(Node $node): ?array

as you return array of nodes.

[Mirko-Tebaldi]

Thanks, but I cannot do this as I explained. I need to do an addNodeBeforeNode.
I am not able to diagnose the error

[Mirko-Tebaldi]

Resolved !

i was wrong creating the FuncCall argument.

i passed a Variable instead of an Arg

So I fixed

 $new_argo_0 = new Variable('date_as_string');

into

    $new_argo_0 =  new Arg(
        new Variable('date_as_string')
    );

Now I can add the new assignment before current node (where current node is already changed !)

    $this->nodesToAddCollector->addNodeBeforeNode(
        $new_assign_node,
        $node,
    );

    return $node;

[TomasVotruba]

Great job 👍 We're glad you've find a solution!