Replies: 1 comment 1 reply
-
|
Per @TomasVotruba comment at rectorphp/rector-src#3514 (comment) , I think this should be on rector extension instead of core. Yes, You can register service via |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hello! First of all, thanks for the excellent work with this library! Definitely a great addition to my toolbox.
I was looking for a way to generate an HTML report like Codeception's code coverage report and, as of #1455, the closest I could get was through the Json Output Formatter.
A couple of days ago I had some time to spare, so I made it possible to output an HTML file like so:
The generated report so far contains a summary and side-by-side diffs. Example screenshots:
So, I have 2 questions:
1: Do you think it would be useful to include this feature in the core library? If so, I can submit a PR
2: If not, I'd publish it as an extension, but first I'd like to know whether this is the proper way of letting Rector be aware of this class: I'm currently doing it through Symfony's DI mechanism like this:
Thanks for your attention!
(also, suggestions are welcome!)
Beta Was this translation helpful? Give feedback.
All reactions