rector using PHPStan prefixed nette/utils

[staabm]

I am wondering why rector is using PHPStan prefixed nette/utils, even though it declares a dependency on nette/utils itself

background of my question is, that I want to test some nette/utils improvements, but this is kind of hard because of rector is using the PHPStan prefixed classes

[TomasVotruba]

Hey, thanks for the improvement!

How many of nette/utils classes we use? If just a couple, I think it might be worth it to port them directly to Rector, so we can make them simple and fast :)

[staabm]

I think we mostly use them for DI indirect via PHPStan.

I saw your experiments with laravel DI: in case these will get more broad application, we still need nette DI for PHPStan, right?

[TomasVotruba]

I think we mostly use them for DI indirect via PHPStan.

I see 👍

I saw your experiments with laravel DI: in case these will get more broad application, we still need nette DI for PHPStan, right?

Yes, you're right. The part I want to check if laravel/di would be faster/cheaper for Rector. I feel like Symfony is great for web application, but not for light CLI like we have here.

[staabm]

We need to think about, whether its worth it to have a diffferent DI then phpstan itself is using.

from a runtime performance point of view, the current solution is slow because of configurable rules.
in recent PHPStan releases the DI nearly does not show up in profiles. Maybe we are using it not as designed.

[TomasVotruba]

You've good points. Having real number for using nette/di and laravel/di would be very helpful here 👍

[staabm]

seems the change is not worth it