Use new minor version for breaking changes #8059
gisostallenberg
started this conversation in
General
Replies: 1 comment 2 replies
-
|
Good point 🙏 , I'll try to think about it in next releases. The linked parent node removal is promoted since Rector 0.17: https://github.com/rectorphp/rector/releases/tag/0.17.0 The best way to keep up is to follow release notes on rector/rector repository. |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
To allow related packages to have proper version constraints I think any breaking change should increment the minor version, while in pre v1 version.
Release https://github.com/rectorphp/rector/releases/tag/0.17.3 introduced a break by removing findParentType. Due to this
driftingly/rector-laravelis not working properly with this version (see driftingly/rector-laravel#121).It could have a version constraint
rector/rector:^0.17and not break if rector would have incremented to 0.18.0.Beta Was this translation helpful? Give feedback.
All reactions