make method static if its called from static method

[themark147]

hello community is there any rule for making methods static if they are called from static method

example input:

final class DemoFile
{
    public static function run()
    {
        $this->a();
    }
    
    public function a()
    {
        return 1;
    }
}

expected output

final class DemoFile
{
    public static function run()
    {
        self::a();
    }
    
    public static function a()
    {
        return 1;
    }
}

its because I migrated unit tests from 9 to 10 but I had non static calls of methods in data providers. And after migration data providers became static

thanks a lot

[samsonasik]

Hi, you may looking for StaticDataProviderClassMethodRector see https://github.com/rectorphp/rector-phpunit/blob/main/docs/rector_rules_overview.md#staticdataproviderclassmethodrector

[themark147]

nope cause I already have dataProviders as static method but in these providers Im callin others methods which are NON static and I need to rewrite them as static

public static function provideData()
     {
         yield [$this->random()]; <-- and this have to be rewrite like this: self::random()
     }
public function random(): int <-- and this as public STATIC function ...
{
    return 1;
}

[samsonasik]

I see, could you create failing fixture PR for it to https://github.com/rectorphp/rector-phpunit/tree/main/rules-tests/PHPUnit100/Rector/Class_/StaticDataProviderClassMethodRector/Fixture ? Thank you.

[themark147]

sure I will try :))

[themark147]

here it is @samsonasik rectorphp/rector-phpunit#255 😊