Ability to add new required arguments

[brandonkelly]

Rector\Arguments\ValueObject\ArgumentAdder requires that you specify a default value for the argument.

Related to #8240, it would be nice if there was a RequiredArgumentAdder alternative that could be used to add a new argument without a default value.

$rectorConfig
    ->ruleWithConfiguration(ArgumentAdderRector::class, [
        new RequiredArgumentAdder('SomeExampleClass', 'someMethod', 0, 'someArgument', new ObjectType('SomeType')),
    ]);

 $someObject = new SomeExampleClass;
 $someObject->someMethod();

 class MyCustomClass extends SomeExampleClass
 {
-    public function someMethod()
+    public function someMethod(SomeType $someArgument)
     {
     }
 }

[staabm]

Adding a new parameter to a method signature itself does not seem very useful.

The harder question would be, to fix all the call-sites. since you are adding a new non defaulting param, you need to adjust every call.

Without more context and constraints this seems undoable from a logic point of view

[brandonkelly]

ArgumentAdderRector already exists, FWIW. I’m just asking for the ability to omit the default value.

My use case is craftcms/rector, which helps Craft CMS plugins with major Craft version upgrades. Craft 5.0 adds a couple new arguments to existing methods that plugins could be extending. The base methods’ arguments don’t have default values, so it’s weird that extended methods created via Rector (here) will have default arguments that aren’t necessary.