replace php constant index to named index

[rakucmr]

In php 4, and php 5 a constant if not found is automatically converted to string so a code like this is ok:

$array[constant_index]

is equivalent to

$array['constant_index']

How to use rector to convert these types of indexes to work correctly in php 7 / 8?

Thanks!

[samsonasik]

I think you can create custom rule for that, as creating rule for core is too risky for core:

• You need to ensure all constants loaded via $rectorConfig->bootstrapFiles(), ensure that it actually not a constant
• then, change the ArrayDimFetch, if its dim is a ConstFetch that not exists via :

if ($this->reflectionProvider->hasConstant(new Name($constantName), $scope)) {

If not, change to string, you can check rector's SensitiveConstantNameRector which change to case sensitive constant name instead:

rector/rules/Php73/Rector/ConstFetch/SensitiveConstantNameRector.php

Lines 78 to 80 in ae4c0b7

	if ($this->reflectionProvider->hasConstant(new Name($constantName), $scope)) {
	return null;
	}

and create custom rule based on your needs.