How do I find the reasoning behind changes? #8725
fds-github
started this conversation in
General
Replies: 1 comment 3 replies
-
|
|
Beta Was this translation helpful? Give feedback.
3 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
I just started using Rector to check/fix my code for PHP 8, but I'm finding that it's doing a lot of general improvement along the way. What a great tool!
Is there a way to find the explanation/justification behind rules? Most of they time it's self-evident, but sometimes it's not clear to me. The particular example I'm looking at now is StaticCallOnNonStaticToInstanceCallRector. My assumption would have been that instantiating the class to make a call is less efficient and doesn't add any value. I also assume I'm wrong, since Rector incorporated this rule, but how can I learn the error of my reasoning? I've looked at rector_rules_overview.md, but the explanation is minimal.
Thanks for any help, and moreover all the work on a great tool!
Beta Was this translation helpful? Give feedback.
All reactions