Why does AddOverrideAttributeToOverriddenMethodsRector ignores implementation of abstract methods?

[EvilKarter]

What is the reason that the rector rule AddOverrideAttributeToOverriddenMethodsRector not add the Override to the implentation of abstract methods?

The PHP Documentation says The rule of thumb is: If changing the method signature would result in the Fatal error: Declaration of X must be compatible with Y error message, the #[\Override] attribute is satisfied and does not emit an error.
https://wiki.php.net/rfc/marking_overriden_methods#semantics

here my playgroud example:
https://getrector.com/demo/d66b4627-9f82-4449-ae37-df2d3468d4f9

[samsonasik]

That's expected, see PR:

• Fix interface implementer in AddOverrideAttributeToOverriddenMethodsRector, add override only in case of overiding parent method with contents rector-src#6447

for reasoning.

[EvilKarter]

OK, but doesn't that contradict the official description of the attribute?
https://www.php.net/manual/en/class.override.php#override.intro

This attribute is used to indicate that a method is intended to override a method of a parent class or that it implements a method defined in an interface.

But the psalm rule MissingOverrideAttribute also takes interfaces and abstract parent methods into account.

So shouldn't the rule be adapted so that it conforms to the official description?

[samsonasik]

code analysis suggestion can be ignored, that's not necessarily cause error on runtime. I think you can create custom rule for your needs, as that's adding attribute on implements interface is mostly preference.