RenameVariableToMatchNewTypeRector doesn't work for me on Rector 2.0.10

[prescriptionlifeline]

Here's the rule I'm trying to use:

https://getrector.com/rule-detail/rename-variable-to-match-new-type-rector

Here's my rector.php:

<?php

use Rector\Config\RectorConfig;
use Rector\Naming\Rector\ClassMethod\RenameVariableToMatchNewTypeRector;

return RectorConfig::configure()
    ->withRules([
        RenameVariableToMatchNewTypeRector::class,
    ]);

I only have one file in the src/ directory - test.php:

<?php

final class SomeClass
{
    public function run()
    {
       $search = new DreamSearch();
       $search->advance();
    }
}

When I run vendor/bin/rector process src --dry-run here's the output that I get:

 1/1 [============================] 100%


 [OK] Rector is done!

The output I'd expect to get is this:

final class SomeClass
{
    public function run()
    {
-        $search = new DreamSearch();
-        $search->advance();
+        $dreamSearch = new DreamSearch();
+        $dreamSearch->advance();
    }
}

vendor/bin/rector --version returns "Rector 2.0.10"

Any ideas? Or does RenameVariableToMatchNewTypeRector just not work?

[samsonasik]

It seems working ok, see https://getrector.com/demo/cb118305-4e91-41d0-aa05-8904fbfeca11

Ensure that the DreamSearch is autoloaded correctly so PHPStan can locate it.

[samsonasik]

It only registered under class method, it seems was used to avoid risky change on global variable usage https://github.com/rectorphp/rector-src/blob/a2b010d3152c065aeb91bdbcd5437b8645a3f7c7/rules/Naming/Rector/ClassMethod/RenameVariableToMatchNewTypeRector.php#L67

[prescriptionlifeline]

I'd like to modify that rule for my specific use case and I'd like it if my modification could support global variable usage.

I was trying to find another rector rule that works globally but haven't had a lot of like. Like I understand that RenameVariableToMatchNewTypeRector could be riskier than others because it's modifying two lines. Like what if there are statements between the object instantiation and the method call on the object? RenameVariableToMatchNewTypeRector still works.

In light of that I thought I'd try a simpler rule - one that only ever modifies one line at a time. To that end I found RoundingModeEnumRector, however, that rule doesn't work, either, in the global namespace:

https://getrector.com/demo/0eecddba-f4c4-4343-8fc6-49d17f561ba4

Does Rector just not work in the global namespace?

[samsonasik]

RoundingModeEnumRector is php 8.4 feature rule, the server is using php 8.2, if you need to enforce apply it, you can define withPhpversion(), see https://getrector.com/demo/45e78615-625d-4c62-9156-3596f26fe408

modifing all variables under namespace is doable with StmtsAwareInterface, that can be a feature which feel free to contribute to make it work, but it will make more risky :)

[prescriptionlifeline]

So I'm trying to make RenameVariableToMatchNewTypeRector work in the global namespace and to do that I made the following changes to RenameVariableToMatchNewTypeRector.php:

    public function getNodeTypes(): array
    {
-        return [ClassMethod::class];
+        return [\Rector\Contract\PhpParser\Node\StmtsAwareInterface::class];
    }

-    private function getAssignsOfNew(ClassMethod $classMethod) : array
+    private function getAssignsOfNew(\Rector\Contract\PhpParser\Node\StmtsAwareInterface $classMethod): array

Now I'm getting this error:

         "System error: "Rector\NodeManipulator\FunctionLikeManipulator::resolveParamNames(): Argument #1
         ($functionLike) must be of type PhpParser\Node\FunctionLike,
         Rector\PhpParser\Node\CustomNode\FileWithoutNamespace given, called in
                       r\vendor\rector\rector\rules\Naming\Naming\ConflictingNameResolver.php84"


         #0 c:\path\to\test\rector\vendor\rector\rector\rules\Naming\Naming\ConflictingNameResolver.php(84):
         Rector\NodeManipulator\FunctionLikeManipulator->resolveParamNames(Object(Rector\PhpParser\Node\CustomNode\File
         WithoutNamespace))
         #1 c:\path\to\test\rector\vendor\rector\rector\rules\Naming\Naming\ConflictingNameResolver.php(70):
         Rector\Naming\Naming\ConflictingNameResolver->resolveConflictingVariableNamesForNew(Object(Rector\PhpParser\No
         de\CustomNode\FileWithoutNamespace))
         #2 c:\path\to\test\rector\vendor\rector\rector\rules\Naming\Guard\BreakingVariableRenameGuard.php(79):
         Rector\Naming\Naming\ConflictingNameResolver->hasNameIsInFunctionLike('dreamSearch',
         Object(Rector\PhpParser\Node\CustomNode\FileWithoutNamespace))
         #3
         c:\path\to\test\rector\vendor\rector\rector\rules\Naming\Rector\ClassMethod\RenameVariableToMatchNewTypeRector.php(102
         ): Rector\Naming\Guard\BreakingVariableRenameGuard->shouldSkipVariable('search', 'dreamSearch',
         Object(Rector\PhpParser\Node\CustomNode\FileWithoutNamespace), Object(PhpParser\Node\Expr\Variable))
         #4 c:\path\to\test\rector\vendor\rector\rector\src\Rector\AbstractRector.php(112):
         Rector\Naming\Rector\ClassMethod\RenameVariableToMatchNewTypeRector->refactor(Object(Rector\PhpParser\Node\Cus
         tomNode\FileWithoutNamespace))
         #5 c:\path\to\test\rector\vendor\rector\rector\vendor\nikic\php-parser\lib\PhpParser\NodeTraverser.php(173):
         Rector\Rector\AbstractRector->enterNode(Object(Rector\PhpParser\Node\CustomNode\FileWithoutNamespace))
         #6 c:\path\to\test\rector\vendor\rector\rector\vendor\nikic\php-parser\lib\PhpParser\NodeTraverser.php(71):
         PhpParser\NodeTraverser->traverseArray(Array)
         #7 c:\path\to\test\rector\vendor\rector\rector\src\PhpParser\NodeTraverser\RectorNodeTraverser.php(49):
         PhpParser\NodeTraverser->traverse(Array)
         #8 c:\path\to\test\rector\vendor\rector\rector\src\Application\FileProcessor.php(95):
         Rector\PhpParser\NodeTraverser\RectorNodeTraverser->traverse(Array)
         #9 c:\path\to\test\rector\vendor\rector\rector\src\Application\ApplicationFileProcessor.php(174):
         Rector\Application\FileProcessor->processFile(Object(Rector\ValueObject\Application\File),
         Object(Rector\ValueObject\Configuration))
         #10 c:\path\to\test\rector\vendor\rector\rector\src\Application\ApplicationFileProcessor.php(151):
         Rector\Application\ApplicationFileProcessor->processFile(Object(Rector\ValueObject\Application\File),
         Object(Rector\ValueObject\Configuration))
         #11 c:\path\to\test\rector\vendor\rector\rector\src\Application\ApplicationFileProcessor.php(128):
         Rector\Application\ApplicationFileProcessor->processFiles(Array, Object(Rector\ValueObject\Configuration),
         Object(Closure), Object(Closure))
         #12 c:\path\to\test\rector\vendor\rector\rector\src\Console\Command\ProcessCommand.php(162):
         Rector\Application\ApplicationFileProcessor->run(Object(Rector\ValueObject\Configuration),
         Object(RectorPrefix202503\Symfony\Component\Console\Input\ArgvInput))
         #13 c:\path\to\test\rector\vendor\rector\rector\vendor\symfony\console\Command\Command.php(285):
         Rector\Console\Command\ProcessCommand->execute(Object(RectorPrefix202503\Symfony\Component\Console\Input\ArgvI
         nput), Object(RectorPrefix202503\Symfony\Component\Console\Output\ConsoleOutput))
         #14 c:\path\to\test\rector\vendor\rector\rector\vendor\symfony\console\Application.php(900):
         RectorPrefix202503\Symfony\Component\Console\Command\Command->run(Object(RectorPrefix202503\Symfony\Component\
         Console\Input\ArgvInput), Object(RectorPrefix202503\Symfony\Component\Console\Output\ConsoleOutput))
         #15 c:\path\to\test\rector\vendor\rector\rector\vendor\symfony\console\Application.php(279):
         RectorPrefix202503\Symfony\Component\Console\Application->doRunCommand(Object(Rector\Console\Command\ProcessCo
         mmand), Object(RectorPrefix202503\Symfony\Component\Console\Input\ArgvInput),
         Object(RectorPrefix202503\Symfony\Component\Console\Output\ConsoleOutput))
         #16 c:\path\to\test\rector\vendor\rector\rector\src\Console\ConsoleApplication.php(53):
         RectorPrefix202503\Symfony\Component\Console\Application->doRun(Object(RectorPrefix202503\Symfony\Component\Co
         nsole\Input\ArgvInput), Object(RectorPrefix202503\Symfony\Component\Console\Output\ConsoleOutput))
         #17 c:\path\to\test\rector\vendor\rector\rector\vendor\symfony\console\Application.php(162):
         Rector\Console\ConsoleApplication->doRun(Object(RectorPrefix202503\Symfony\Component\Console\Input\ArgvInput),
         Object(RectorPrefix202503\Symfony\Component\Console\Output\ConsoleOutput))
         #18 c:\path\to\test\rector\vendor\rector\rector\bin\rector.php(130):
         RectorPrefix202503\Symfony\Component\Console\Application->run()
         #19 c:\path\to\test\rector\vendor\rector\rector\bin\rector(5): require_once('C:\\path\\to\\test...')
         #20 c:\path\to\test\rector\vendor\bin\rector(119): include('C:\\path\\to\\test...')
         #21 {main}". On line: 21

Any ideas?

[samsonasik]

The best way to learn is be slow, take time to learn it :)