Create New_ node without unnecessary parenthesis in PHP 8.4

[marcreichel]

How do I prevent the creation of the unnecessary parentheses around the New_ node when chained with other methods (in PHP 8.4)?

In my custom rule, I want to create a New_ node. All works fine so far. But when the New_ node is chained together with followup methods the new MyClass() gets surrounded by parentheses.

I have the NewMethodCallWithoutParenthesesRector rule enabled as well. But currently, I have to run rector twice, to get the desired result.

Shouldn't the New_ node be created without parentheses in the first place (for PHP 8.4 code only of course)?

[calebdw]

That sounds like something PHP-Parser needs to implement when it converts the nodes back into source code...

The NewMethodCallWithoutParenthesesRector is doing a lot of manual token manipulation to remove the parentheses

[marcreichel]

Unfortunately, the order of the rules does not seem to be helpful. It may indeed be an issue with PHP-Parser that they need to address.

Thank you.

[samsonasik]

@marcreichel could you provide reproducible code at https://getrector.com/demo ? Thank you.

[marcreichel]

@samsonasik I cannot manage to create a custom rule there. It keeps crashing or saying my refactor method is not compatible.

But here's a example:

PHP snippet to change

<?php

final class DemoFile
{
    public function run()
    {
        return \Foo::hello()->world();
    }
}

Config rector.php

<?php

use PhpParser\Node;
use PhpParser\Node\Expr\New_;
use PhpParser\Node\Expr\StaticCall;
use PhpParser\Node\Name\FullyQualified;
use Rector\Config\RectorConfig;
use Rector\Php84\Rector\MethodCall\NewMethodCallWithoutParenthesesRector;
use Rector\Rector\AbstractRector;
use Rector\ValueObject\PhpVersion;

class MyRule extends AbstractRector
{
    public function getNodeTypes(): array
    {
        return [StaticCall::class];
    }
    
    public function refactor(Node $node): Node
    {
        return new New_(new FullyQualified(\Foo::class));
    }
}

return RectorConfig::configure()
    ->withRules([
        MyRule::class,
        NewMethodCallWithoutParenthesesRector::class,
    ])
    ->withPhpVersion(PhpVersion::PHP_84);

[samsonasik]

That's expected, you create "brand new" Node, which means "reprint" by default, which old tokens doesn't have knowledge about it yet. Run rector twice is the way :)

[marcreichel]

I will try to explain it to my colleagues 😅 Some of them are really frustrated about how it can be, that Rector complains about code itself generated/suggested in the previous run 😄