Skip to content

Incorrect behavior of AddReturnTypeDeclarationBasedOnParentClassMethodRectorΒ #9144

@jderusse

Description

@jderusse

Bug Report

Subject Details
Rector version last dev-main
Installed as composer dependency

Minimal PHP Code Causing Issue

See https://getrector.com/demo/277cad10-bafa-4d2a-b570-09b1a686de18

<?php

class CParent
{
    public function __destruct()
    {}
}

class Child extends CParent
{
    public function __destruct()
    {}
}

Responsible rules

  • AddReturnTypeDeclarationBasedOnParentClassMethodRector

Expected Behavior

The rule suggest the following diff

class Child extends CParent
 {
-    public function __destruct()
+    public function __destruct(): void
     {}
 }

Which is not valid: __destruct() cannot declare a return type

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions