cs

Author: TomasVotruba

src/Command/GenerateCommand.php

@@ -6,6 +6,7 @@
 
 use Nette\Utils\FileSystem;
 use Rector\SmokeTestgen\FIleSystem\TestsDirectoryResolver;
+use Rector\SmokeTestgen\Templating\TemplateDecorator;
 use Rector\SmokeTestgen\TestTemplateResolver;
 use Rector\SmokeTestgen\Utils\JsonFileLoader;
 use Rector\SmokeTestgen\Utils\TestPathResolver;
@@ -19,7 +20,8 @@ final class GenerateCommand extends Command
 {
     public function __construct(
         private readonly TestsDirectoryResolver $testsDirectoryResolver,
-        private readonly TestTemplateResolver $testTemplateResolver
+        private readonly TestTemplateResolver $testTemplateResolver,
+        private readonly TemplateDecorator $templateDecorator
     ) {
         parent::__construct();
     }
@@ -46,12 +48,13 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             $symfonyStyle->warning(
                 'No test templates found for the required packages. Make sure you project uses Composer to manage version and has Symfony/Doctrine packages listed in "require" section'
             );
+
             return self::FAILURE;
         }
 
         $symfonyStyle->newLine();
         $symfonyStyle->writeln(sprintf(
-            'Found <fg=yellow>%d smoke test%s</>, that might come handy',
+            'Found <fg=yellow>%d smoke test%s</> that might come handy',
             count($testByPackageSubscribers),
             count($testByPackageSubscribers) > 1 ? 's' : ''
         ));
@@ -67,7 +70,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
             }
 
             $templateContents = FileSystem::read($testByPackageSubscriber->getTemplateFilePath());
-            $templateContents = $this->addjustTestFileNamespace($templateContents, $smokeTestsDirectory);
+            $templateContents = $this->templateDecorator->decorate($templateContents, $smokeTestsDirectory);
 
             FileSystem::write($projectTestFilePath, $templateContents);
 
@@ -85,6 +88,8 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         $projectTestCaseFilePath = $smokeTestsDirectory . '/AbstractContainerTestCase.php';
         if (! file_exists($projectTestCaseFilePath)) {
             $templateContents = FileSystem::read(__DIR__ . '/../../templates/Symfony/AbstractContainerTestCase.php');
+            $templateContents = $this->templateDecorator->decorate($templateContents, $smokeTestsDirectory);
+
             FileSystem::write($projectTestCaseFilePath, $templateContents);
         }
 
@@ -116,17 +121,4 @@ private function resolveProjectRequiredPackageNames(string $projectDirectory): a
 
         return $packageNames;
     }
-
-    private function addjustTestFileNamespace(string $templateContents, string $smokeTestsDirectory): string
-    {
-        if ($smokeTestsDirectory === 'tests/Unit/Smoke') {
-            // default one, nothing to adjust
-            return $templateContents;
-        }
-
-        $namespace = str_replace('/', '\\', $smokeTestsDirectory);
-        $namespace = lcfirst($namespace);
-
-        return str_replace('namespace App\Tests\Unit\Smoke', 'namespace App\\' . $namespace, $templateContents);
-    }
 }

src/Templating/TemplateDecorator.php

@@ -0,0 +1,50 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\SmokeTestgen\Templating;
+
+final class TemplateDecorator
+{
+    public function decorate(string $templateContents, string $smokeTestsDirectory): string
+    {
+        $templateContents = $this->adjustKernelClass($templateContents);
+
+        return $this->adjustNamespace($smokeTestsDirectory, $templateContents);
+    }
+
+    private function adjustKernelClass(string $templateContents): string
+    {
+        $kernelClass = $this->resolveKernelClass();
+
+        return str_replace('__KERNEL_CLASS_PLACEHOLDER__', $kernelClass, $templateContents);
+    }
+
+    private function resolveKernelClass(): string
+    {
+        // use correct Kernel class
+        if (class_exists('App\Kernel')) {
+            return 'App\Kernel';
+        }
+
+        if (class_exists('AppKernel')) {
+            return 'AppKernel';
+        }
+
+        return 'Kernel';
+    }
+
+    private function adjustNamespace(string $templateContents, string $smokeTestsDirectory): string
+    {
+        if ($smokeTestsDirectory === 'tests/Unit/Smoke') {
+            // default one, nothing to adjust
+            return $templateContents;
+        }
+
+        // @todo check with composer.json "psr-4" in require-dev
+        $namespace = str_replace('/', '\\', $smokeTestsDirectory);
+        $namespace = lcfirst($namespace);
+
+        return str_replace('namespace App\Tests\Unit\Smoke', 'namespace App\\' . $namespace, $templateContents);
+    }
+}

src/Utils/TestPathResolver.php

@@ -5,16 +5,13 @@
 namespace Rector\SmokeTestgen\Utils;
 
 use Rector\SmokeTestgen\Contract\TestByPackageSubscriberInterface;
-use Webmozart\Assert\Assert;
 
 final class TestPathResolver
 {
     public static function resolve(
         TestByPackageSubscriberInterface $testByPackageSubscriber,
         string $smokeTestsDirectory
     ): string {
-        Assert::fileExists($testByPackageSubscriber->getTemplateFilePath());
-
         $absolutePath = $testByPackageSubscriber->getTemplateFilePath();
         $testFileBasename = pathinfo($absolutePath, PATHINFO_BASENAME);
 

templates/Symfony/AbstractContainerTestCase.php

@@ -4,7 +4,6 @@
 
 namespace App\Tests\Unit\Smoke;
 
-use AppKernel;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\DependencyInjection\Container;
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
@@ -21,11 +20,11 @@ abstract class AbstractContainerTestCase extends TestCase
     protected function setUp(): void
     {
         // @todo configure your test environment: most likely "tests", "ci" or "dev"
-        $appKernel = new AppKernel('tests', true);
-        $appKernel->boot();
+        $kernel = new \__KERNEL_CLASS_PLACEHOLDER__('tests', true);
+        $kernel->boot();
 
-        self::$kernel = $appKernel;
-        self::$container = $appKernel->getContainer()->get('test.service_container');
+        self::$kernel = $kernel;
+        self::$container = $kernel->getContainer()->get('test.service_container');
     }
 
     /**