generic errors

[staabm]

I wonder why we get a error here:

the type the error is suggesting, is already in place?

[TomasVotruba]

That would be false positive.

[staabm]

reproducer:

<?php

/**
 * @template T
 */
class GenericA {
}

class User {
    /** @param GenericA<string> $g */
    public function doFoo(GenericA $g):void {

    }
}

/** @param GenericA<string> $g */
function doFoo($g):void {
    $user = new User();
    $user->doFoo($g);
}

leads

 ------ ----------------------------------------------------------------------------------------- 
  11     Parameters should have "GenericA<string>" types as the only types passed to this method  
         🪪  typePerfect.narrowPublicClassMethodParamType                                         
 ------ ----------------------------------------------------------------------------------------- 

[staabm]

another interessting repro simliar but different:

<?php

/**
 * @template T
 */
class GenericA {
}

/**
 * @template T of string
 */
class User {
    /**
     * @param GenericA<T> $g
     */
    public function doFoo(GenericA $g):void {

    }
}

/** @param GenericA<string> $g */
function doFoo($g):void {
    $user = new User();
    $user->doFoo($g);
}

leads

 ------ ----------------------------------------------------------------------------------------- 
  16     Parameters should have "GenericA<string>" types as the only types passed to this method  
         🪪  typePerfect.narrowPublicClassMethodParamType                                         
 ------ ----------------------------------------------------------------------------------------- 

[TomasVotruba]

I've added provided test fixture and it seems passing:
#63

If the issue is still there, please provide exact failing fixture i a PR, so we can catch it and verify it 👍

[staabm]

I am coming back here, as the initial problem still exists, and I am now able to reproduce it outside the test-suite.

I am not sure, why it does not reproduce in the test-suite though.

---

1. put the following code into src/test.php:

<?php

/**
 * @template T
 */
class GenericA {
}

/**
 * @template T of string
 */
class User {
    /**
     * @param GenericA<T> $g
     */
    public function doFoo(GenericA $g):void {

    }
}

/** @param GenericA<string> $g */
function doFoo($g):void {
    $user = new User();
    $user->doFoo($g);
}

2. adjust config/extension.neon and enable the narrow_param setting

--- a/config/extension.neon
+++ b/config/extension.neon
@@ -14,7 +14,7 @@ parametersSchema:
 # defaults
 parameters:
     type_perfect:
-        narrow_param: false
+        narrow_param: true
         narrow_return: false
         no_mixed: false
         null_over_false: false

3. run vendor/bin/phpstan over the full codebase (you cannot run it on a single-file, as PHPStan would not run collectors).
   =>

 ------ ----------------------------------------------------------------------------------------- 
  Line   src/test.php                                                                             
 ------ ----------------------------------------------------------------------------------------- 
  16     Parameters should have "GenericA<string>" types as the only types passed to this method  
         🪪  typePerfect.narrowPublicClassMethodParamType                                         
         at src/test.php:16                                                                       
 ------ -----------------------------------------------------------------------------------------