Add support for datetime

Author: kou

lib/activerecord_adbc_adapter/database_statements.rb

@@ -22,6 +22,8 @@ def perform_query(raw_connection,
               else
                 array = Arrow::StringArray.new([type_casted_bind])
               end
+            when DateTime
+              array = Arrow::TimestampArray.new(:micro, [type_casted_bind])
             when Date
               array = Arrow::Date32Array.new([type_casted_bind])
             else

lib/activerecord_adbc_adapter/result.rb

@@ -82,6 +82,8 @@ def resolve_type(data_type)
         ActiveRecord::Type::String.new
       when Arrow::Date32DataType
         ActiveRecord::Type::Date.new
+      when Arrow::TimestampDataType
+        ActiveRecord::Type::DateTime.new
       else
         raise "Unknown: #{data_type.inspect}"
       end

lib/activerecord_adbc_adapter/schema_statements.rb

@@ -8,6 +8,7 @@ module SchemaStatements
         primary_key: "bigserial PRIMARY KEY",
         string: {name: "character varying"},
         binary: {name: "bytea"},
+        datetime: {name: "timestamp without time zone"},
       },
       "sqlite" => {
         primary_key: "integer PRIMARY KEY AUTOINCREMENT NOT NULL",

test/helper.rb

@@ -19,10 +19,28 @@ def included(base)
       end
     end
 
+    def backend
+      ENV["ACTIVERECORD_ADBC_ADAPTER_BACKEND"]
+    end
+
+    def duckdb?
+      backend == "duckdb"
+    end
+
+    def postgresql?
+      backend == "postgresql"
+    end
+
+    def sqlite?
+      return false if duckdb?
+      return false if postgresql?
+      true
+    end
+
     def setup_connection
       suffix = nil
       database = "ar_adbc_test"
-      case ENV["ACTIVERECORD_ADBC_ADAPTER_BACKEND"]
+      case backend
       when "duckdb"
         suffix = ".duckdb"
         path_key = :path

test/test_type.rb

@@ -1,7 +1,7 @@
 class TestType < Test::Unit::TestCase
   include Helper::Sandbox
 
-  def test_bigint
+  def test_bigint_active_record
     ActiveRecord::Base.connection.create_table("users") do |table|
       table.bigint :bigint
     end
@@ -10,7 +10,17 @@ def test_bigint
                  User.first)
   end
 
-  def test_integer
+  def test_bigint_arrow
+    ActiveRecord::Base.connection.create_table("users") do |table|
+      table.bigint :bigint
+    end
+    User.create!(bigint: 2 ** 32)
+    assert_equal(Arrow::Table.new(id: Arrow::Int64Array.new([1]),
+                                  bigint: Arrow::Int64Array.new([2 ** 32])),
+                 User.to_arrow)
+  end
+
+  def test_integer_active_record
     ActiveRecord::Base.connection.create_table("users") do |table|
       table.integer :integer
     end
@@ -19,7 +29,22 @@ def test_integer
                  User.first)
   end
 
-  def test_float
+  def test_integer_arrow
+    ActiveRecord::Base.connection.create_table("users") do |table|
+      table.integer :integer
+    end
+    User.create!(integer: 1)
+    if sqlite?
+      array = Arrow::Int64Array.new([1])
+    else
+      array = Arrow::Int32Array.new([1])
+    end
+    assert_equal(Arrow::Table.new(id: Arrow::Int64Array.new([1]),
+                                  integer: array),
+                 User.to_arrow)
+  end
+
+  def test_float_active_record
     ActiveRecord::Base.connection.create_table("users") do |table|
       table.float :float
     end
@@ -28,7 +53,22 @@ def test_float
                  User.first)
   end
 
-  def test_binary
+  def test_float_arrow
+    ActiveRecord::Base.connection.create_table("users") do |table|
+      table.float :float
+    end
+    User.create!(float: 2.9)
+    if duckdb?
+      array = Arrow::FloatArray.new([2.9])
+    else
+      array = Arrow::DoubleArray.new([2.9])
+    end
+    assert_equal(Arrow::Table.new(id: Arrow::Int64Array.new([1]),
+                                  float: array),
+                 User.to_arrow)
+  end
+
+  def test_binary_active_record
     ActiveRecord::Base.connection.create_table("users") do |table|
       table.binary :binary
     end
@@ -37,7 +77,17 @@ def test_binary
                  User.first)
   end
 
-  def test_string
+  def test_binary_arrow
+    ActiveRecord::Base.connection.create_table("users") do |table|
+      table.binary :binary
+    end
+    User.create!(binary: "Hello".b)
+    assert_equal(Arrow::Table.new(id: Arrow::Int64Array.new([1]),
+                                  binary: Arrow::BinaryArray.new(["Hello".b])),
+                 User.to_arrow)
+  end
+
+  def test_string_active_record
     ActiveRecord::Base.connection.create_table("users") do |table|
       table.string :string
     end
@@ -46,16 +96,17 @@ def test_string
                  User.first)
   end
 
-  def test_text
+  def test_text_arrow
     ActiveRecord::Base.connection.create_table("users") do |table|
       table.text :text
     end
     User.create!(text: "Hello")
-    assert_equal(User.new(id: 1, text: "Hello"),
-                 User.first)
+    assert_equal(Arrow::Table.new(id: Arrow::Int64Array.new([1]),
+                                  text: Arrow::StringArray.new(["Hello"])),
+                 User.to_arrow)
   end
 
-  def test_date
+  def test_date_active_record
     ActiveRecord::Base.connection.create_table("users") do |table|
       table.date :date
     end
@@ -64,4 +115,38 @@ def test_date
     assert_equal(User.new(id: 1, date: date),
                  User.first)
   end
+
+  def test_date_arrow
+    omit("TODO") if sqlite?
+    ActiveRecord::Base.connection.create_table("users") do |table|
+      table.date :date
+    end
+    date = Date.new(2025, 7, 20)
+    User.create!(date: date)
+    assert_equal(Arrow::Table.new(id: Arrow::Int64Array.new([1]),
+                                  date: Arrow::Date32Array.new([date])),
+                 User.to_arrow)
+  end
+
+  def test_datetime_active_record
+    ActiveRecord::Base.connection.create_table("users") do |table|
+      table.datetime :datetime
+    end
+    datetime = DateTime.new(2025, 7, 20, 20, 40, 23)
+    User.create!(datetime: datetime)
+    assert_equal(User.new(id: 1, datetime: datetime),
+                 User.first)
+  end
+
+  def test_datetime
+    omit("TODO") if sqlite?
+    ActiveRecord::Base.connection.create_table("users") do |table|
+      table.datetime :datetime
+    end
+    datetime = DateTime.new(2025, 7, 20, 20, 40, 23)
+    User.create!(datetime: datetime)
+    assert_equal(Arrow::Table.new(id: Arrow::Int64Array.new([1]),
+                                  datetime: Arrow::TimestampArray.new(:micro, [datetime])),
+                 User.to_arrow)
+  end
 end