Created fork. Modernized code. Should I make pull request?

[eddietejeda]

Hey team,

Check out my fork using the latest version of DuckDB and Ruby.

https://github.com/eddietejeda/activerecord-duckdb-adapter

Should I make a pull request?

[kou]

It seems that you removed all commits in this repository and replaced them entirely.

Could you split your changes to small logical units and open a PR per small logical unit? For example: RSpec -> ActiveSupport::TestCase

You will need to open multiple PRs for it but we can work together in this repository after it.

What do you think about this approach?

[eddietejeda]

I wasn't sure the project was active, so I am glad you want to work together on this. Let me see what I can do.

It was a fairly big rewrite, so the pull requests will have to be large. But I will make sure to preserve the history.

How does that sound?

[kou]

If one pull request is enough small to review, many pull requests are OK. (I (and other Red Data Tools members) can't review one large pull request...)

Let's try it.