Cope with numpy memleak (e.g. np.array([1,2,3]) < 1)

mknkmyzk · mrkn · commit 799205dd0f9c · 2023-08-28T22:44:58.000+09:00
diff --git a/ext/pycall/pycall.c b/ext/pycall/pycall.c
@@ -792,8 +792,9 @@ pycall_libpython_helpers_m_compare(VALUE mod, VALUE op, VALUE pyptr_a, VALUE pyp
   if (!res) {
     pycall_pyerror_fetch_and_raise("PyObject_RichCompare in pycall_libpython_helpers_m_compare");
   }
-
-  return pycall_pyobject_to_ruby(res);
+  VALUE obj = pycall_pyobject_to_ruby(res);
+  pycall_Py_DecRef(res);
+  return obj;
 }
 
 static int is_pyobject_wrapper(VALUE obj);

Original file line number	Diff line number	Diff line change
`@@ -792,8 +792,9 @@ pycall_libpython_helpers_m_compare(VALUE mod, VALUE op, VALUE pyptr_a, VALUE pyp`
`792`	`792`	`if (!res) {`
`793`	`793`	`pycall_pyerror_fetch_and_raise("PyObject_RichCompare in pycall_libpython_helpers_m_compare");`
`794`	`794`	`}`
`795`		`-`
`796`		`- return pycall_pyobject_to_ruby(res);`
	`795`	`+ VALUE obj = pycall_pyobject_to_ruby(res);`
	`796`	`+ pycall_Py_DecRef(res);`
	`797`	`+ return obj;`
`797`	`798`	`}`
`798`	`799`
`799`	`800`	`static int is_pyobject_wrapper(VALUE obj);`