test wikipedia: don't override #download

Author: kou

lib/datasets/wikipedia.rb

@@ -53,9 +53,15 @@ def each(&block)
     end
 
     private
+    def base_name
+      "#{@language}wiki-latest-#{type_in_path}.xml.bz2"
+    end
+
+    def data_path
+      cache_dir_path + base_name
+    end
+
     def open_data(&block)
-      base_name = "#{@language}wiki-latest-#{type_in_path}.xml.bz2"
-      data_path = cache_dir_path + base_name
       data_url = "https://dumps.wikimedia.org/#{@language}wiki/latest/#{base_name}"
       bz2 = Enumerator.new do |yielder|
         download(data_path, data_url) do |bz2_chunk|

test/test-wikipedia.rb

@@ -21,10 +21,10 @@ def teardown
       end
 
       test("#each") do
-        def @dataset.download(output_path, url)
-          xml_path = output_path.sub_ext("")
-          xml_path.open("w") do |xml_file|
-            xml_file.puts(<<-XML)
+        data_path = @dataset.__send__(:data_path)
+        xml_path = data_path.sub_ext("")
+        xml_path.open("w") do |xml_file|
+          xml_file.puts(<<-XML)
 <mediawiki
    xmlns="http://www.mediawiki.org/xml/export-0.10/"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
@@ -55,11 +55,10 @@ def @dataset.download(output_path, url)
     </revision>
   </page>
 </mediawiki>
-            XML
-          end
-          unless system("bzip2", xml_path.to_s)
-            raise "failed to run bzip2"
-          end
+          XML
+        end
+        unless system("bzip2", xml_path.to_s)
+          raise "failed to run bzip2"
         end
 
         contributor = Datasets::Wikipedia::Contributor.new("user", 10)