Merge pull request #3 from red-gate/arrow-function

Only arrow function style

Author: Buster-Darragh-Major

eslint.config.js

@@ -15,6 +15,7 @@ export default tseslint.config(
       ],
       '@typescript-eslint/explicit-function-return-type': 'off',
       '@typescript-eslint/no-explicit-any': 'warn',
+      'func-style': ['error', 'expression', { allowArrowFunctions: true }],
     },
   }
 );

flyway/migrate/dist/index.cjs

@@ -15,6 +15,7 @@ export default tseslint.config(
       ],
       '@typescript-eslint/explicit-function-return-type': 'off',
       '@typescript-eslint/no-explicit-any': 'warn',
+      'func-style': ['error', 'expression', { allowArrowFunctions: true }],
     },
   }
 );

flyway/migrate/eslint.config.js

@@ -6,7 +6,7 @@ import { INPUT_DEFINITIONS } from './inputs.js';
 /**
  * Build the Flyway command arguments from inputs
  */
-export function buildFlywayArgs(inputs: FlywayMigrateInputs): string[] {
+export const buildFlywayArgs = (inputs: FlywayMigrateInputs): string[] => {
   const args: string[] = ['migrate'];
 
   // Process all standard inputs
@@ -45,12 +45,12 @@ export function buildFlywayArgs(inputs: FlywayMigrateInputs): string[] {
   }
 
   return args;
-}
+};
 
 /**
  * Parse extra args string into array, handling quoted strings
  */
-export function parseExtraArgs(extraArgs: string): string[] {
+export const parseExtraArgs = (extraArgs: string): string[] => {
   const args: string[] = [];
   let current = '';
   let inQuotes = false;
@@ -80,12 +80,12 @@ export function parseExtraArgs(extraArgs: string): string[] {
   }
 
   return args;
-}
+};
 
 /**
  * Check if Flyway is available in PATH
  */
-export async function checkFlywayInstalled(): Promise<boolean> {
+export const checkFlywayInstalled = async (): Promise<boolean> => {
   try {
     await exec.exec('flyway', ['--version'], {
       silent: true,
@@ -95,12 +95,12 @@ export async function checkFlywayInstalled(): Promise<boolean> {
   } catch {
     return false;
   }
-}
+};
 
 /**
  * Get Flyway version
  */
-export async function getFlywayVersion(): Promise<string> {
+export const getFlywayVersion = async (): Promise<string> => {
   let stdout = '';
 
   await exec.exec('flyway', ['--version'], {
@@ -115,12 +115,12 @@ export async function getFlywayVersion(): Promise<string> {
   // Parse version from output like "Flyway Community Edition 10.0.0"
   const match = stdout.match(/Flyway\s+(?:Community|Teams|Enterprise)\s+Edition\s+(\d+\.\d+\.\d+)/);
   return match ? match[1] : 'unknown';
-}
+};
 
 /**
  * Run the Flyway migrate command
  */
-export async function runFlyway(inputs: FlywayMigrateInputs): Promise<FlywayRunResult> {
+export const runFlyway = async (inputs: FlywayMigrateInputs): Promise<FlywayRunResult> => {
   const args = buildFlywayArgs(inputs);
 
   let stdout = '';
@@ -148,12 +148,12 @@ export async function runFlyway(inputs: FlywayMigrateInputs): Promise<FlywayRunR
   const exitCode = await exec.exec('flyway', args, options);
 
   return { exitCode, stdout, stderr };
-}
+};
 
 /**
  * Mask sensitive values in args for logging
  */
-export function maskArgsForLog(args: string[]): string[] {
+export const maskArgsForLog = (args: string[]): string[] => {
   const sensitivePatterns = [/^-password=/i, /^-user=/i, /^-vault\.token=/i, /^-url=.*password=/i];
 
   return args.map((arg) => {
@@ -165,15 +165,17 @@ export function maskArgsForLog(args: string[]): string[] {
     }
     return arg;
   });
-}
+};
 
 /**
  * Parse Flyway output to extract migration information
  */
-export function parseFlywayOutput(stdout: string): {
+export const parseFlywayOutput = (
+  stdout: string
+): {
   migrationsApplied: number;
   schemaVersion: string;
-} {
+} => {
   let migrationsApplied = 0;
   let schemaVersion = 'unknown';
 
@@ -210,21 +212,21 @@ export function parseFlywayOutput(stdout: string): {
   }
 
   return { migrationsApplied, schemaVersion };
-}
+};
 
 /**
  * Set action outputs
  */
-export function setOutputs(outputs: FlywayMigrateOutputs): void {
+export const setOutputs = (outputs: FlywayMigrateOutputs): void => {
   core.setOutput('exit-code', outputs.exitCode.toString());
   core.setOutput('flyway-version', outputs.flywayVersion);
   core.setOutput('migrations-applied', outputs.migrationsApplied.toString());
   core.setOutput('schema-version', outputs.schemaVersion);
-}
+};
 
 /**
  * Convert kebab-case to camelCase
  */
-function toCamelCase(str: string): string {
+const toCamelCase = (str: string): string => {
   return str.replace(/-([a-z])/g, (_, letter) => letter.toUpperCase());
-}
+};

flyway/migrate/src/flyway-runner.ts

@@ -129,7 +129,7 @@ export const INPUT_DEFINITIONS: InputDefinition[] = [
 /**
  * Parse boolean input from string
  */
-export function parseBoolean(value: string | undefined): boolean | undefined {
+export const parseBoolean = (value: string | undefined): boolean | undefined => {
   if (value === undefined || value === '') {
     return undefined;
   }
@@ -141,12 +141,12 @@ export function parseBoolean(value: string | undefined): boolean | undefined {
     return false;
   }
   throw new Error(`Invalid boolean value: ${value}`);
-}
+};
 
 /**
  * Parse number input from string
  */
-export function parseNumber(value: string | undefined): number | undefined {
+export const parseNumber = (value: string | undefined): number | undefined => {
   if (value === undefined || value === '') {
     return undefined;
   }
@@ -155,13 +155,15 @@ export function parseNumber(value: string | undefined): number | undefined {
     throw new Error(`Invalid number value: ${value}`);
   }
   return num;
-}
+};
 
 /**
  * Parse placeholders from comma-separated key=value pairs
  * Format: "key1=value1,key2=value2"
  */
-export function parsePlaceholders(value: string | undefined): Record<string, string> | undefined {
+export const parsePlaceholders = (
+  value: string | undefined
+): Record<string, string> | undefined => {
   if (value === undefined || value === '') {
     return undefined;
   }
@@ -189,12 +191,12 @@ export function parsePlaceholders(value: string | undefined): Record<string, str
   }
 
   return Object.keys(placeholders).length > 0 ? placeholders : undefined;
-}
+};
 
 /**
  * Get all inputs from the GitHub Action context
  */
-export function getInputs(): FlywayMigrateInputs {
+export const getInputs = (): FlywayMigrateInputs => {
   const url = core.getInput('url', { required: true });
 
   const inputs: FlywayMigrateInputs = { url };
@@ -236,23 +238,23 @@ export function getInputs(): FlywayMigrateInputs {
   }
 
   return inputs;
-}
+};
 
 /**
  * Convert kebab-case to camelCase
  */
-export function toCamelCase(str: string): string {
+export const toCamelCase = (str: string): string => {
   return str.replace(/-([a-z])/g, (_, letter) => letter.toUpperCase());
-}
+};
 
 /**
  * Mask secret inputs in the log
  */
-export function maskSecrets(inputs: FlywayMigrateInputs): void {
+export const maskSecrets = (inputs: FlywayMigrateInputs): void => {
   if (inputs.password) {
     core.setSecret(inputs.password);
   }
   if (inputs.vaultToken) {
     core.setSecret(inputs.vaultToken);
   }
-}
+};

flyway/migrate/src/inputs.ts

@@ -8,7 +8,7 @@ import {
   setOutputs,
 } from './flyway-runner.js';
 
-async function run(): Promise<void> {
+const run = async (): Promise<void> => {
   try {
     // Check if Flyway is installed
     const flywayInstalled = await checkFlywayInstalled();
@@ -66,6 +66,6 @@ async function run(): Promise<void> {
       core.setFailed('An unexpected error occurred');
     }
   }
-}
+};
 
 run();