Merge remote-tracking branch 'upstream/main'

Author: dchourasia

tests/kfto/kfto_sft_llm_test.go

@@ -119,7 +119,7 @@ func kftoSftLlm(t *testing.T, image string, gpu Accelerator, modelName string) {
 		"eval_strategy: epoch": "eval_strategy: 'no'",
 		"logging_steps: 1":     "logging_steps: 10",
 		"output_dir: /mnt/shared/Meta-Llama-3.1-8B-Instruct":              fmt.Sprintf("output_dir: /mnt/shared/%s", modelName),
-		"api_server = \\\"<API_SERVER>\\\"":                               fmt.Sprintf("api_server = \\\"%s\\\"", GetOpenShiftApiUrl(test)),
+		"%pip install -U kubeflow-training ":                              "#%pip install -U kubeflow-training ",
 		"token = \\\"<TOKEN>\\\"":                                         fmt.Sprintf("token = \\\"%s\\\"", userToken),
 		"#configuration.verify_ssl = False":                               "configuration.verify_ssl = False",
 		"name=\\\"sft\\\"":                                                fmt.Sprintf("name=\\\"sft-%s\\\"", namespace.Name),
@@ -128,7 +128,7 @@ func kftoSftLlm(t *testing.T, image string, gpu Accelerator, modelName string) {
 		"base_image=\\\"quay.io/modh/training:py311-cuda124-torch251\\\"": fmt.Sprintf("base_image=\\\"%s\\\"", image),
 		"\"HF_TOKEN\\\": \\\"\\\"":                                        fmt.Sprintf("\"HF_TOKEN\\\": \\\"%s\\\"", hfToken),
 		"claim_name=\\\"shared\\\"":                                       fmt.Sprintf("claim_name=\\\"%s\\\"", notebookPVC.Name),
-		"\"client.get_job_logs(\\n\",":                                    "\"client.wait_for_job_conditions(\\n\",",
+		"\"_ = client.get_job_logs(\\n\",":                                "\"client.wait_for_job_conditions(\\n\",",
 		"\"    follow=True,\\n\",":                                        "\"    wait_timeout=1800,\\n\",\n\t\"    polling_interval=60,\\n\",",
 		"os.environ[\\\"TENSORBOARD_PROXY_URL\\\"]":                       "#os.environ[\\\"TENSORBOARD_PROXY_URL\\\"]",
 		"%load_ext tensorboard":                                           "#%load_ext tensorboard",