Skip to content

Commit ece14ca

Browse files
committed
Merge remote-tracking branch 'upstream/main'
2 parents 6dd2c37 + ab99d2c commit ece14ca

File tree

4 files changed

+770
-0
lines changed

4 files changed

+770
-0
lines changed

tests/common/support/environment.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ const (
5959
storageBucketMnistDir = "AWS_STORAGE_BUCKET_MNIST_DIR"
6060
storageBucketFashionMnistDir = "AWS_STORAGE_BUCKET_FASHION_MNIST_DIR"
6161
storageBucketOsftDir = "AWS_STORAGE_BUCKET_OSFT_DIR"
62+
storageBucketSftDir = "AWS_STORAGE_BUCKET_SFT_DIR"
6263

6364
// Name of existing namespace to be used for test
6465
testNamespaceNameEnvVar = "TEST_NAMESPACE_NAME"
@@ -191,6 +192,11 @@ func GetStorageBucketOsftDir() (string, bool) {
191192
return storage_bucket_osft_dir, exists
192193
}
193194

195+
func GetStorageBucketSftDir() (string, bool) {
196+
storage_bucket_sft_dir, exists := os.LookupEnv(storageBucketSftDir)
197+
return storage_bucket_sft_dir, exists
198+
}
199+
194200
func GetPipIndexURL() string {
195201
return lookupEnvOrDefault(pipIndexURL, "https://pypi.python.org/simple")
196202
}

tests/trainer/kubeflow_sdk_test.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,3 +34,9 @@ func TestOsftTrainingHubMultiNodeMultiGPU(t *testing.T) {
3434
Tags(t, KftoCuda, MultiNodeMultiGpu(2, support.NVIDIA, 1)) // TODO: may need to be updated once https://issues.redhat.com/browse/RHOAIENG-30719 and https://issues.redhat.com/browse/RHOAIENG-24552 are resolved
3535
sdktests.RunOsftTrainingHubMultiGpuDistributedTraining(t)
3636
}
37+
38+
// TestSftTrainingHubMultiNodeMultiGPU tests SFT training using TrainingHubTrainer
39+
func TestSftTrainingHubMultiNodeMultiGPU(t *testing.T) {
40+
Tags(t, KftoCuda, MultiNodeMultiGpu(2, support.NVIDIA, 1))
41+
sdktests.RunSftTrainingHubMultiGpuDistributedTraining(t)
42+
}

0 commit comments

Comments
 (0)