Skip to content

Commit 252b192

Browse files
nananosirovaHumairAK
authored andcommitted
fix: encode PF icons as uris for proper bundling
1 parent dd59f5a commit 252b192

File tree

6 files changed

+10
-32
lines changed

6 files changed

+10
-32
lines changed

mlflow/server/js/src/common/styles/patternfly/icons/arrows-alt-v.svg

Lines changed: 0 additions & 4 deletions
This file was deleted.

mlflow/server/js/src/common/styles/patternfly/icons/caret-down.svg

Lines changed: 0 additions & 4 deletions
This file was deleted.

mlflow/server/js/src/common/styles/patternfly/icons/long-arrow-alt-down.svg

Lines changed: 0 additions & 4 deletions
This file was deleted.

mlflow/server/js/src/common/styles/patternfly/icons/long-arrow-alt-up.svg

Lines changed: 0 additions & 4 deletions
This file was deleted.

mlflow/server/js/src/common/styles/patternfly/icons/question-circle.svg

Lines changed: 0 additions & 6 deletions
This file was deleted.

mlflow/server/js/src/common/styles/patternfly/pf-shell-overrides.scss

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -456,18 +456,18 @@
456456

457457
/* Table sort icons */
458458
[aria-sort='none'] .table-header-icon-container .anticon::before {
459-
mask-image: url('./icons/arrows-alt-v.svg');
460-
-webkit-mask-image: url('./icons/arrows-alt-v.svg');
459+
mask-image: url('data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCAyNTYgNTEyIj4KICA8cGF0aCBkPSJNMjE0LjA1OSAzNzcuOTQxSDE2OFYxMzQuMDU5aDQ2LjA1OWMyMS4zODIgMCAzMi4wOS0yNS44NTEgMTYuOTcxLTQwLjk3MUwxNDQuOTcxIDcuMDI5Yy05LjM3My05LjM3My0yNC41NjgtOS4zNzMtMzMuOTQxIDBMMjQuOTcxIDkzLjA4OGMtMTUuMTE5IDE1LjExOS00LjQxMSA0MC45NzEgMTYuOTcxIDQwLjk3MUg4OHYyNDMuODgySDQxLjk0MWMtMjEuMzgyIDAtMzIuMDkgMjUuODUxLTE2Ljk3MSA0MC45NzFsODYuMDU5IDg2LjA1OWM5LjM3MyA5LjM3MyAyNC41NjggOS4zNzMgMzMuOTQxIDBsODYuMDU5LTg2LjA1OWMxNS4xMi0xNS4xMTkgNC40MTItNDAuOTcxLTE2Ljk3LTQwLjk3MXoiLz4KPC9zdmc+Cgo=');
460+
-webkit-mask-image: url('data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCAyNTYgNTEyIj4KICA8cGF0aCBkPSJNMjE0LjA1OSAzNzcuOTQxSDE2OFYxMzQuMDU5aDQ2LjA1OWMyMS4zODIgMCAzMi4wOS0yNS44NTEgMTYuOTcxLTQwLjk3MUwxNDQuOTcxIDcuMDI5Yy05LjM3My05LjM3My0yNC41NjgtOS4zNzMtMzMuOTQxIDBMMjQuOTcxIDkzLjA4OGMtMTUuMTE5IDE1LjExOS00LjQxMSA0MC45NzEgMTYuOTcxIDQwLjk3MUg4OHYyNDMuODgySDQxLjk0MWMtMjEuMzgyIDAtMzIuMDkgMjUuODUxLTE2Ljk3MSA0MC45NzFsODYuMDU5IDg2LjA1OWM5LjM3MyA5LjM3MyAyNC41NjggOS4zNzMgMzMuOTQxIDBsODYuMDU5LTg2LjA1OWMxNS4xMi0xNS4xMTkgNC40MTItNDAuOTcxLTE2Ljk3LTQwLjk3MXoiLz4KPC9zdmc+Cgo=');
461461
}
462462

463463
[aria-sort='ascending'] .table-header-icon-container .anticon::before {
464-
mask-image: url('./icons/long-arrow-alt-up.svg');
465-
-webkit-mask-image: url('./icons/long-arrow-alt-up.svg');
464+
mask-image: url('data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCAyNTYgNTEyIj4KICA8cGF0aCBkPSJNODggMTY2LjA1OVY0NjhjMCA2LjYyNyA1LjM3MyAxMiAxMiAxMmg1NmM2LjYyNyAwIDEyLTUuMzczIDEyLTEyVjE2Ni4wNTloNDYuMDU5YzIxLjM4MiAwIDMyLjA5LTI1Ljg1MSAxNi45NzEtNDAuOTcxbC04Ni4wNTktODYuMDU5Yy05LjM3My05LjM3My0yNC41NjktOS4zNzMtMzMuOTQxIDBsLTg2LjA1OSA4Ni4wNTljLTE1LjExOSAxNS4xMTktNC40MTEgNDAuOTcxIDE2Ljk3MSA0MC45NzFIODh6Ii8+Cjwvc3ZnPgoK');
465+
-webkit-mask-image: url('data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCAyNTYgNTEyIj4KICA8cGF0aCBkPSJNODggMTY2LjA1OVY0NjhjMCA2LjYyNyA1LjM3MyAxMiAxMiAxMmg1NmM2LjYyNyAwIDEyLTUuMzczIDEyLTEyVjE2Ni4wNTloNDYuMDU5YzIxLjM4MiAwIDMyLjA5LTI1Ljg1MSAxNi45NzEtNDAuOTcxbC04Ni4wNTktODYuMDU5Yy05LjM3My05LjM3My0yNC41NjktOS4zNzMtMzMuOTQxIDBsLTg2LjA1OSA4Ni4wNTljLTE1LjExOSAxNS4xMTktNC40MTEgNDAuOTcxIDE2Ljk3MSA0MC45NzFIODh6Ii8+Cjwvc3ZnPgoK');
466466
}
467467

468468
[aria-sort='descending'] .table-header-icon-container .anticon::before {
469-
mask-image: url('./icons/long-arrow-alt-down.svg');
470-
-webkit-mask-image: url('./icons/long-arrow-alt-down.svg');
469+
mask-image: url('data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCAyNTYgNTEyIj4KICA8cGF0aCBkPSJNMTY4IDM0NS45NDFWNDRjMC02LjYyNy01LjM3My0xMi0xMi0xMmgtNTZjLTYuNjI3IDAtMTIgNS4zNzMtMTIgMTJ2MzAxLjk0MUg0MS45NDFjLTIxLjM4MiAwLTMyLjA5IDI1Ljg1MS0xNi45NzEgNDAuOTcxbDg2LjA1OSA4Ni4wNTljOS4zNzMgOS4zNzMgMjQuNTY5IDkuMzczIDMzLjk0MSAwbDg2LjA1OS04Ni4wNTljMTUuMTE5LTE1LjExOSA0LjQxMS00MC45NzEtMTYuOTcxLTQwLjk3MUgxNjh6Ii8+Cjwvc3ZnPgoK');
470+
-webkit-mask-image: url('data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCAyNTYgNTEyIj4KICA8cGF0aCBkPSJNMTY4IDM0NS45NDFWNDRjMC02LjYyNy01LjM3My0xMi0xMi0xMmgtNTZjLTYuNjI3IDAtMTIgNS4zNzMtMTIgMTJ2MzAxLjk0MUg0MS45NDFjLTIxLjM4MiAwLTMyLjA5IDI1Ljg1MS0xNi45NzEgNDAuOTcxbDg2LjA1OSA4Ni4wNTljOS4zNzMgOS4zNzMgMjQuNTY5IDkuMzczIDMzLjk0MSAwbDg2LjA1OS04Ni4wNTljMTUuMTE5LTE1LjExOSA0LjQxMS00MC45NzEtMTYuOTcxLTQwLjk3MUgxNjh6Ii8+Cjwvc3ZnPgoK');
471471
}
472472

473473
aside > nav > ul {
@@ -647,8 +647,8 @@
647647
width: 1em;
648648
height: 1em;
649649
background-color: var(--pf-t--global--icon--color--subtle);
650-
mask-image: url('./icons/question-circle.svg');
651-
-webkit-mask-image: url('./icons/question-circle.svg');
650+
mask-image: url('data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCAxNiAxNiI+CiAgPHBhdGggZmlsbD0iY3VycmVudENvbG9yIiBkPSJNOSAxMC41YTEgMSAwIDEgMS0yIDAgMSAxIDAgMCAxIDIgMCIvPgogIDxwYXRoIGZpbGw9ImN1cnJlbnRDb2xvciIgZD0iTTkuNDE2IDQuMzNhMi4xIDIuMSAwIDAgMC0xLjE5NS0uMzMgMi4yIDIuMiAwIDAgMC0uOTQuMTgzIDIuMSAyLjEgMCAwIDAtLjcyNy41MyAyLjIgMi4yIDAgMCAwLS40NTcuODA3IDEuNjUgMS42NSAwIDAgMC0uMDczLjk4MmMuMDc2LjMyMi4zNDcuNDk4LjYzLjQ5OC4zNzggMCAuNjUyLS4zMi43NS0uNjMyLjAzMS0uMDk4LjA3NC0uMTkuMTI5LS4yNzRhLjc3Ljc3IDAgMCAxIC4yNjMtLjI0Ny44LjggMCAwIDEgLjM3NS0uMDg3LjczLjczIDAgMCAxIC41NDYuMTk3cS4xOTEuMTk2LjE5MS41MDVjMCAuMTM0LS4wMzQuMjUtLjEwMS4zNDdhMS41IDEuNSAwIDAgMS0uMjM4LjI2N2MtLjA5MS4wOC0uMTg0LjE1OC0uMjc5LjIzM2EyLjMgMi4zIDAgMCAwLS4yNzQuMjdjLS4wODUuMS0uMTU2LjIxNy0uMjE0LjM1NGExLjIgMS4yIDAgMCAwLS4wODcuNDd2LjE5NmEuNjUuNjUgMCAwIDAgLjY1NC42NTQuNjUuNjUgMCAwIDAgLjY1NC0uNjU0di0uMTFhLjYuNiAwIDAgMSAuMDU1LS4yNi45LjkgMCAwIDEgLjE1Ni0uMjM0IDIgMiAwIDAgMSAuMjMxLS4yMTRsLjI4LS4yMjdjLjEtLjA4Mi4xOTYtLjE3Ny4yODgtLjI4NS4wOTItLjEwNy4xNy0uMjMyLjIzNi0uMzc1cy4wOTktLjMxLjA5OS0uNTA0QTEuNTUgMS41NSAwIDAgMCA5LjQxNiA0LjMzIi8+CiAgPHBhdGggZmlsbD0iY3VycmVudENvbG9yIiBmaWxsLXJ1bGU9ImV2ZW5vZGQiIGQ9Ik04IDE0QTYgNiAwIDEgMCA4IDJhNiA2IDAgMCAwIDAgMTJtMC0xLjVhNC41IDQuNSAwIDEgMCAwLTkgNC41IDQuNSAwIDAgMCAwIDkiIGNsaXAtcnVsZT0iZXZlbm9kZCIvPgo8L3N2Zz4KCg==');
651+
-webkit-mask-image: url('data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCAxNiAxNiI+CiAgPHBhdGggZmlsbD0iY3VycmVudENvbG9yIiBkPSJNOSAxMC41YTEgMSAwIDEgMS0yIDAgMSAxIDAgMCAxIDIgMCIvPgogIDxwYXRoIGZpbGw9ImN1cnJlbnRDb2xvciIgZD0iTTkuNDE2IDQuMzNhMi4xIDIuMSAwIDAgMC0xLjE5NS0uMzMgMi4yIDIuMiAwIDAgMC0uOTQuMTgzIDIuMSAyLjEgMCAwIDAtLjcyNy41MyAyLjIgMi4yIDAgMCAwLS40NTcuODA3IDEuNjUgMS42NSAwIDAgMC0uMDczLjk4MmMuMDc2LjMyMi4zNDcuNDk4LjYzLjQ5OC4zNzggMCAuNjUyLS4zMi43NS0uNjMyLjAzMS0uMDk4LjA3NC0uMTkuMTI5LS4yNzRhLjc3Ljc3IDAgMCAxIC4yNjMtLjI0Ny44LjggMCAwIDEgLjM3NS0uMDg3LjczLjczIDAgMCAxIC41NDYuMTk3cS4xOTEuMTk2LjE5MS41MDVjMCAuMTM0LS4wMzQuMjUtLjEwMS4zNDdhMS41IDEuNSAwIDAgMS0uMjM4LjI2N2MtLjA5MS4wOC0uMTg0LjE1OC0uMjc5LjIzM2EyLjMgMi4zIDAgMCAwLS4yNzQuMjdjLS4wODUuMS0uMTU2LjIxNy0uMjE0LjM1NGExLjIgMS4yIDAgMCAwLS4wODcuNDd2LjE5NmEuNjUuNjUgMCAwIDAgLjY1NC42NTQuNjUuNjUgMCAwIDAgLjY1NC0uNjU0di0uMTFhLjYuNiAwIDAgMSAuMDU1LS4yNi45LjkgMCAwIDEgLjE1Ni0uMjM0IDIgMiAwIDAgMSAuMjMxLS4yMTRsLjI4LS4yMjdjLjEtLjA4Mi4xOTYtLjE3Ny4yODgtLjI4NS4wOTItLjEwNy4xNy0uMjMyLjIzNi0uMzc1cy4wOTktLjMxLjA5OS0uNTA0QTEuNTUgMS41NSAwIDAgMCA5LjQxNiA0LjMzIi8+CiAgPHBhdGggZmlsbD0iY3VycmVudENvbG9yIiBmaWxsLXJ1bGU9ImV2ZW5vZGQiIGQ9Ik04IDE0QTYgNiAwIDEgMCA4IDJhNiA2IDAgMCAwIDAgMTJtMC0xLjVhNC41IDQuNSAwIDEgMCAwLTkgNC41IDQuNSAwIDAgMCAwIDkiIGNsaXAtcnVsZT0iZXZlbm9kZCIvPgo8L3N2Zz4KCg==');
652652
mask-size: contain;
653653
mask-repeat: no-repeat;
654654
mask-position: center;
@@ -1374,8 +1374,8 @@
13741374
width: 0.8em;
13751375
height: 0.8em;
13761376
background-color: currentColor;
1377-
mask-image: url('./icons/caret-down.svg');
1378-
-webkit-mask-image: url('./icons/caret-down.svg');
1377+
mask-image: url('data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCAzMjAgNTEyIj4KICA8cGF0aCBmaWxsPSJjdXJyZW50Q29sb3IiIGQ9Ik0zMS4zIDE5MmgyNTcuM2MxNy44IDAgMjYuNyAyMS41IDE0LjEgMzQuMUwxNzQuMSAzNTQuOGMtNy44IDcuOC0yMC41IDcuOC0yOC4zIDBMMTcuMiAyMjYuMUM0LjYgMjEzLjUgMTMuNSAxOTIgMzEuMyAxOTJ6Ii8+Cjwvc3ZnPgoK');
1378+
-webkit-mask-image: url('data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCAzMjAgNTEyIj4KICA8cGF0aCBmaWxsPSJjdXJyZW50Q29sb3IiIGQ9Ik0zMS4zIDE5MmgyNTcuM2MxNy44IDAgMjYuNyAyMS41IDE0LjEgMzQuMUwxNzQuMSAzNTQuOGMtNy44IDcuOC0yMC41IDcuOC0yOC4zIDBMMTcuMiAyMjYuMUM0LjYgMjEzLjUgMTMuNSAxOTIgMzEuMyAxOTJ6Ii8+Cjwvc3ZnPgoK');
13791379
mask-size: contain;
13801380
mask-repeat: no-repeat;
13811381
mask-position: center;

0 commit comments

Comments
 (0)