Skip to content

Commit 1a45303

Browse files
jstouracharshad16
authored andcommitted
[GHA] Pin kustomize version we use in our test to the particular version
Recently the kustomize test started to fail for us since the kustomize version 5.4 introduced some breaking changes for which we will need to update our manifests to be compatible. This work will be tracked in [1]. In the meantime, we should pin kustomize version in our GHA to the version that is used by the opendatahub-operator in runtime [2]. [1] https://issues.redhat.com/browse/RHOAIENG-11679 [2] https://github.com/red-hat-data-services/rhods-operator/blob/rhoai-2.12/go.mod#L30-L31
1 parent 02acf1f commit 1a45303

File tree

1 file changed

+12
-5
lines changed

1 file changed

+12
-5
lines changed

.github/workflows/code-quality.yaml

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -116,16 +116,23 @@ jobs:
116116
echo "Hadolint done"
117117
118118
# This simply checks that the manifests and respective kustomization.yaml finishes without an error.
119+
# Version of the kustomize that operator use in runtime to apply these changes is determined by:
120+
# https://github.com/red-hat-data-services/rhods-operator/blob/7ccc405135f99c014982d7e297b8949e970dd750/go.mod#L28-L29
121+
# and then to match appropriate kustomize release https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize%2Fv5.0.2
119122
- name: Check kustomize manifest
120123
id: kustomize-manifests
121124
run: |
122-
kubectl version --client=true
125+
KUSTOMIZE_VERSION=5.0.2
126+
wget "https://github.com/kubernetes-sigs/kustomize/releases/download/kustomize/v${KUSTOMIZE_VERSION}/kustomize_v${KUSTOMIZE_VERSION}_linux_amd64.tar.gz"
127+
tar -xvf kustomize*
128+
129+
./kustomize version
123130
echo "----------------------------------------------------------"
124-
echo "Starting 'kubectl kustomize manifests/base'"
131+
echo "Starting './kustomize build manifests/base'"
125132
echo "----------------------------------------------------------"
126-
kubectl kustomize manifests/base
133+
./kustomize build manifests/base
127134
128135
echo "----------------------------------------------------------"
129-
echo "Starting 'kubectl kustomize manifests/overlays/additional'"
136+
echo "Starting './kustomize build manifests/overlays/additional'"
130137
echo "----------------------------------------------------------"
131-
kubectl kustomize manifests/overlays/additional
138+
./kustomize build manifests/overlays/additional

0 commit comments

Comments
 (0)