Skip to content

Commit 391e435

Browse files
authored
Merge pull request #273 from jstourac/cherry-pick-179-to-release-2024a
[release-2024a] Cherry pick #179, #253 and #254 to release-2024a
2 parents e239e7e + 8cc5dbf commit 391e435

File tree

6 files changed

+13
-12
lines changed

6 files changed

+13
-12
lines changed

base/rhel9-python-3.9/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ LABEL name="rhoai-notebook-base-rhel9-python-3.9" \
1313
WORKDIR /opt/app-root/bin
1414

1515
# Install micropipenv to deploy packages from Pipfile.lock
16-
RUN pip install -U "micropipenv[toml]"
16+
RUN pip install --no-cache-dir -U "micropipenv[toml]"
1717

1818
# Install Python dependencies from Pipfile.lock file
1919

@@ -24,7 +24,7 @@ RUN echo "Installing softwares and packages" && micropipenv install && rm -f ./P
2424
USER root
2525

2626
# Install usefull OS packages
27-
RUN dnf install -y mesa-libGL
27+
RUN dnf install -y mesa-libGL && dnf clean all && rm -rf /var/cache/yum
2828

2929
# Other apps and tools installed as default user
3030
USER 1001

ci/check-params-env.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ PARAMS_ENV_PATH="manifests/base/params.env"
2525

2626
# This value needs to be updated everytime we deliberately change number of the
2727
# images we want to have in the `params.env` file.
28-
EXPECTED_NUM_RECORDS=26
28+
EXPECTED_NUM_RECORDS=27
2929

3030
# ---------------------------- DEFINED FUNCTIONS ----------------------------- #
3131

@@ -185,7 +185,7 @@ function check_image_variable_matches_name_and_commitref() {
185185
;;
186186
odh-habana-notebook-image-n)
187187
expected_name="odh-notebook-habana-jupyter-1.13.0-ubi8-python-3.8"
188-
expected_commitref="2024a"
188+
expected_commitref="release-2024a"
189189
expected_build_name="habana-jupyter-1.13.0-ubi8-python-3.8-amd64"
190190
;;
191191
odh-habana-notebook-image-n-1)

manifests/base/kustomization.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ vars:
213213
name: notebooks-parameters
214214
apiVersion: v1
215215
fieldref:
216-
fieldpath: data.odh-codeserver-notebook-n-1
216+
fieldpath: data.odh-codeserver-notebook-image-n-1
217217
- name: odh-minimal-notebook-image-commit-n
218218
objref:
219219
kind: ConfigMap

manifests/base/params.env

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,5 +23,5 @@ odh-trustyai-notebook-image-n-1=quay.io/modh/odh-trustyai-notebook@sha256:926ed1
2323
odh-trustyai-notebook-image-n-2=quay.io/modh/odh-trustyai-notebook@sha256:8c5e653f6bc6a2050565cf92f397991fbec952dc05cdfea74b65b8fd3047c9d4
2424
odh-habana-notebook-image-n=quay.io/modh/odh-habana-notebooks@sha256:e300c9279587e93742d7cc9a982a286804ad6491f592e48ab6e4bba07c853b54
2525
odh-habana-notebook-image-n-1=quay.io/modh/odh-habana-notebooks@sha256:0f6ae8f0b1ef11896336e7f8611e77ccdb992b49a7942bf27e6bc64d73205d05
26-
odh-codeserver-notebook-n=quay.io/modh/codeserver@sha256:e682a0d2a3990525fb59de409664f3482f0a97bdfe7b440258da6a5b5617bddb
27-
odh-codeserver-notebook-n-1=quay.io/modh/codeserver@sha256:14b73e8a62b98fb9a70cb079b6048121ab0a7798fe1eca0adf06b6716f280115
26+
odh-codeserver-notebook-image-n=quay.io/modh/codeserver@sha256:e682a0d2a3990525fb59de409664f3482f0a97bdfe7b440258da6a5b5617bddb
27+
odh-codeserver-notebook-image-n-1=quay.io/modh/codeserver@sha256:14b73e8a62b98fb9a70cb079b6048121ab0a7798fe1eca0adf06b6716f280115

manifests/base/params.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,4 +107,4 @@ varReference:
107107
- path: spec/tags[]/from/name
108108
kind: ImageStream
109109
apiGroup: image.openshift.io/v1
110-
name: odh-codeserver-notebook-n-1
110+
name: odh-codeserver-notebook-image-n-1

rstudio/rhel9-python-3.9/Dockerfile

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ ENV R_LIBS_USER /opt/app-root/src/Rpackages/4.3
5858
WORKDIR /tmp/
5959

6060
# Install RStudio
61-
RUN wget https://download2.rstudio.org/server/rhel9/x86_64/rstudio-server-rhel-2023.12.1-402-x86_64.rpm && \
61+
RUN wget --progress=dot:giga https://download2.rstudio.org/server/rhel9/x86_64/rstudio-server-rhel-2023.12.1-402-x86_64.rpm && \
6262
yum install -y rstudio-server-rhel-2023.12.1-402-x86_64.rpm && \
6363
rm rstudio-server-rhel-2023.12.1-402-x86_64.rpm && \
6464
yum -y clean all --enablerepo='*'
@@ -68,8 +68,9 @@ RUN chmod 1777 /var/run/rstudio-server && \
6868
mkdir -p /usr/share/doc/R
6969
COPY rstudio/rhel9-python-3.9/rsession.conf /etc/rstudio/rsession.conf
7070

71-
# package installation
72-
RUN dnf install -y libsodium-devel.x86_64 libgit2-devel.x86_64 libcurl-devel harfbuzz-devel.x86_64 fribidi-devel.x86_64 cmake "flexiblas-*"
71+
# package installation
72+
RUN dnf install -y libsodium-devel.x86_64 libgit2-devel.x86_64 libcurl-devel harfbuzz-devel.x86_64 fribidi-devel.x86_64 cmake "flexiblas-*" && \
73+
dnf clean all && rm -rf /var/cache/yum
7374
RUN R -e "install.packages('Rcpp')"
7475

7576
# Install NGINX to proxy RStudio and pass probes check
@@ -142,4 +143,4 @@ WORKDIR /opt/app-root/src
142143

143144
USER 1001
144145

145-
CMD /opt/app-root/bin/run-rstudio.sh
146+
CMD ["/opt/app-root/bin/run-rstudio.sh"]

0 commit comments

Comments
 (0)