Skip to content

Commit c2c4daa

Browse files
authored
ISSUE #1358: fix(gha): include platform in Playwright report artifact name to avoid artifact upload failures due to artifact name clashes (#1375)
1 parent 0b99d37 commit c2c4daa

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

.github/workflows/build-notebooks-TEMPLATE.yaml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,6 +262,8 @@ jobs:
262262
echo "IMAGE_TAG=${IMAGE_TAG}" >> "$GITHUB_OUTPUT"
263263
echo "OUTPUT_IMAGE=${{ env.IMAGE_REGISTRY}}:${{ inputs.target }}-${IMAGE_TAG}" >> "$GITHUB_OUTPUT"
264264
265+
echo "SANITIZED_PLATFORM=$(echo "${{ inputs.platform }}" | sed 's/[^a-zA-Z0-9._-]/_/g')" >> "$GITHUB_OUTPUT"
266+
265267
# endregion
266268

267269
# region Image build
@@ -686,7 +688,7 @@ jobs:
686688
- uses: actions/upload-artifact@v4
687689
if: ${{ !cancelled() && fromJson(inputs.github).event_name == 'pull_request' && contains(inputs.target, 'codeserver') }}
688690
with:
689-
name: "${{ inputs.target }}_playwright-report"
691+
name: "${{ inputs.target }}_${{ steps.calculated_vars.outputs.SANITIZED_PLATFORM }}_playwright-report"
690692
path: tests/browser/playwright-report/
691693
retention-days: 30
692694

0 commit comments

Comments
 (0)