Skip to content

Commit 0e6d664

Browse files
committed
fix(upgrade ide): clean eventual existing Jupyter workbench before test
This assures that there is no Notebook CR for the Jupyter app tile running in the RHOAI instance before we do our test. Also fixes a small string check with the current OpenShift UI appearance
1 parent 646ad73 commit 0e6d664

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

ods_ci/tests/Resources/Page/ODH/JupyterHub/JupyterHubSpawner.robot

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,7 @@ Spawn Notebook With Arguments # robocop: disable
350350
END
351351
END
352352
Spawn Notebook ${spawner_timeout} ${same_tab}
353-
Run Keyword And Warn On Failure Wait Until Page Contains Log in with OpenShift timeout=15s
353+
Run Keyword And Warn On Failure Wait Until Page Contains Log in with timeout=15s
354354
${oauth_prompt_visible} = Is OpenShift OAuth Login Prompt Visible
355355
IF ${oauth_prompt_visible} Click Button Log in with OpenShift
356356
Run Keyword And Warn On Failure Login To Openshift ${username} ${password} ${auth_type}

ods_ci/tests/Tests/0200__rhoai_upgrade/0201__pre_upgrade.robot

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ Resource ../../Resources/Page/ODH/ODHDashboard/ODHDashboardResources.
99
Resource ../../Resources/Page/ODH/ODHDashboard/ODHModelServing.resource
1010
Resource ../../Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/DataConnections.resource
1111
Resource ../../Resources/Page/ODH/JupyterHub/HighAvailability.robot
12+
Resource ../../Resources/Page/ODH/JupyterHub/JupyterLabLauncher.robot
1213
Resource ../../Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/Projects.resource
1314
Resource ../../Resources/Page/ODH/ODHDashboard/ODHDataScienceProject/ModelServer.resource
1415
Resource ../../Resources/Page/ODH/AiApps/Anaconda.resource
@@ -263,6 +264,7 @@ Launch Notebook
263264
... ${username}=${TEST_USER2.USERNAME}
264265
... ${password}=${TEST_USER2.PASSWORD}
265266
... ${auth_type}=${TEST_USER2.AUTH_TYPE}
267+
Clean All Standalone Notebooks
266268
Begin Web Test username=${username} password=${password} auth_type=${auth_type}
267269
Launch Jupyter From RHODS Dashboard Link
268270
Spawn Notebook With Arguments

0 commit comments

Comments
 (0)