Skip to content

Commit 62440b5

Browse files
authored
Merge pull request #14 from vajain-rhods/fix_vll_version
Fix VLLM_VERSION ARG
2 parents e32b88c + c0b2fbe commit 62440b5

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

Dockerfile.rocm.ubi

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@ FROM rocm_devel AS build_vllm
141141
ARG PYTORCH_ROCM_ARCH
142142
ARG PYTHON_VERSION
143143
ARG MAX_JOBS
144+
ARG VLLM_VERSION
144145
ENV MAX_JOBS=${MAX_JOBS}
145146
ENV PYTORCH_ROCM_ARCH=${PYTORCH_ROCM_ARCH}
146147

@@ -159,12 +160,13 @@ RUN --mount=type=cache,target=/root/.cache/ccache \
159160
env CFLAGS="-march=haswell" \
160161
CXXFLAGS="$CFLAGS $CXXFLAGS" \
161162
CMAKE_BUILD_TYPE=Release \
162-
SETUPTOOLS_SCM_PRETEND_VERSION="$VLLM_VERSION" \
163+
SETUPTOOLS_SCM_PRETEND_VERSION="${VLLM_VERSION}" \
163164
python3 setup.py bdist_wheel --dist-dir=dist
164165

165166
#################### libsodium Build IMAGE ####################
166167
FROM rocm_base as libsodium-builder
167168

169+
ARG MAX_JOBS
168170
RUN microdnf install -y --nodocs gcc gzip tar \
169171
&& microdnf clean all
170172

@@ -180,7 +182,7 @@ RUN CFLAGS="-O3 -Wall -Werror=format-security -Wno-unused-function -Wp,-D_GLIBCX
180182
./configure \
181183
--prefix="/usr/" \
182184
--libdir=/usr/lib64 && \
183-
make -j $(nproc) && \
185+
make -j ${MAX_JOBS} && \
184186
make check
185187

186188
##################################################################################################

0 commit comments

Comments
 (0)