Merge pull request #387 from red-hat-storage/revert-352-namespace-4.18

Revert "DFBUGS-2364: [release-4.18] restrict manager to watch selective  namespaces"

Author: agarwal-mudit

cmd/main.go

@@ -21,7 +21,6 @@ import (
 	"flag"
 	"fmt"
 	"os"
-	"strings"
 
 	apiv1alpha1 "github.com/red-hat-storage/ocs-client-operator/api/v1alpha1"
 	"github.com/red-hat-storage/ocs-client-operator/internal/controller"
@@ -109,19 +108,6 @@ func main() {
 
 	ctrl.SetLogger(zap.New(zap.UseFlagOptions(&opts)))
 
-	defaultNamespaces := map[string]cache.Config{}
-	operatorNamespace := utils.GetOperatorNamespace()
-	defaultNamespaces[operatorNamespace] = cache.Config{}
-
-	watchNamespace := utils.GetWatchNamespace()
-	if watchNamespace == "" {
-		setupLog.Info("No value for env WATCH_NAMESPACE is set. Manager will only watch for resources in the operator deployed namespace.")
-	} else {
-		for _, namespace := range strings.Split(watchNamespace, ",") {
-			defaultNamespaces[namespace] = cache.Config{}
-		}
-	}
-
 	subscriptionwebhookSelector := fields.SelectorFromSet(fields.Set{"metadata.name": templates.SubscriptionWebhookName})
 	mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), ctrl.Options{
 		Scheme:                 scheme,
@@ -136,7 +122,6 @@ func main() {
 					Field: subscriptionwebhookSelector,
 				},
 			},
-			DefaultNamespaces: defaultNamespaces,
 		},
 		WebhookServer: webhook.NewServer(webhook.Options{
 			Port:    webhookPort,

pkg/utils/k8sutils.go

@@ -37,10 +37,6 @@ const (
 	// which is the namespace where operator pod is deployed.
 	OperatorNamespaceEnvVar = "OPERATOR_NAMESPACE"
 
-	// WatchNamespaceEnvVar is the constant for env variable WATCH_NAMESPACE
-	// which indicates any other namespace to watch for resources.
-	WatchNamespaceEnvVar = "WATCH_NAMESPACE"
-
 	// OperatorPodNameEnvVar is the constant for env variable OPERATOR_POD_NAME
 	OperatorPodNameEnvVar = "OPERATOR_POD_NAME"
 
@@ -67,10 +63,6 @@ func GetOperatorNamespace() string {
 	return os.Getenv(OperatorNamespaceEnvVar)
 }
 
-func GetWatchNamespace() string {
-	return os.Getenv(WatchNamespaceEnvVar)
-}
-
 func ValidateOperatorNamespace() error {
 	ns := GetOperatorNamespace()
 	if ns == "" {