Merge pull request #724 from iamniting/install-plan

controllers: approve InstallPlans only in RequiresApproval phase

Author: openshift-merge-bot[bot]

controllers/subscriptions.go

@@ -331,6 +331,7 @@ func ApproveInstallPlanForCsv(ctx context.Context, cli client.Client, csvName st
 		if slices.Contains(installPlan.Spec.ClusterServiceVersionNames, csvName) {
 			foundInstallPlan = true
 			if installPlan.Spec.Approval == opv1a1.ApprovalManual &&
+				installPlan.Status.Phase == opv1a1.InstallPlanPhaseRequiresApproval &&
 				!installPlan.Spec.Approved {
 
 				installPlans.Items[i].Spec.Approved = true