FEAT: some improvements.

Author: qtxie

README.md

@@ -8,44 +8,53 @@ An extension with rich support for the [Red Programming language](https://www.re
 * hover to view signatures
 * Interpret or compile Red source file
 
-## Quick Start
+## Settings
 
-1. Install the extension
-2. Download [CLI Red](https://www.red-lang.org/p/download.html) and set the `red.redPath` in the `Settings`
-3. Restart VS Code 
+To enable features like IntelliSense, you need to configure the path to the Red binaries in the `Settings`.
 
-## Settings
+---
+**NOTE**
+
+Restart the VS Code to take effect after changing the `Settings`.
 
-### Specify the full path of the red toolchain
+---
+
+### Set the search path of the red binaries
 
-In order to compile Red source file, you need to configure the path to the Red toolchain in the `Settings`.
+Download the [Red binaries](https://www.red-lang.org/p/download.html) to a local folder, then set the `red.redDir` to it. The plugin will use the latest one according to the filename. 
 
 ```
-"red.redToolChainPath": "/home/user1/tools/red-toolchain"
+"red.redDir": "D:/Tools/Red/"
 ```
 
----
-**NOTE**
+### Set the full path of the red binaries
 
-You can also set the paths for `red` and `red-view`.
+If you want to use a specified version of Red binaries, use the following settings:
 
 ```
 "red.redPath": "/home/user1/tools/red"
 "red.redViewPath": "/home/user1/tools/red-view"
+"red.redToolChainPath": "/home/user1/tools/red-toolchain"
 ```
 
----
-
-### Specify the output folder
+### Set the output folder
 
 You can also configure the directory for output files of the compiler. The current work space (project) directory is used by default.
 
 (**Note**: If no work space directory, the output files are in the same folder as the Red source file.)
 
 
-  ```
-  "red.buildDir": "/home/user1/debug"
-  ```
+```
+"red.buildDir": "/home/user1/debug"
+```
+
+### Turn off the IntelliSense
+
+In case that you don't like this fancy feature. ;)
+
+```
+"red.intelligence": false
+```
 
 ## Shortcuts
 

package.json

@@ -191,6 +191,11 @@
 			"type": "object",
 			"title": "Red",
 			"properties": {
+				"red.redDir": {
+					"type": "string",
+					"default": "",
+					"description": "Path to red binaries directory"
+				},
 				"red.redPath": {
 					"type": "string",
 					"default": "",
@@ -224,12 +229,12 @@
 				"red.intelligence": {
 					"type": "boolean",
 					"default": true,
-					"description": "Whether to enable or disable intelligence."
+					"description": "Check it to enable IntelliSence"
 				},
 				"red.rls-debug": {
 					"type": "boolean",
 					"default": false,
-					"description": "Whether to enable or disable 'Red language server' debug."
+					"description": "Check it to enable 'Red language server' debug"
 				},
 				"red.server.trace.server": {
 					"scope": "window",

red.configuration.json

@@ -7,7 +7,7 @@
         ["[", "]"],
         ["(", ")"]
     ],
-    "wordPattern": "([#:A-Za-z0-9\\+\\-\\*\\/\\@\\$\\%\\^\\&\\_\\=\\<\\>\\~\\!\\?\\[\\]\\{\\}\\.]+)",
+    "wordPattern": "([#:A-Za-z0-9\\+\\-\\*\\$\\^\\&\\_\\=\\~\\!\\?\\.]+)",
     "autoClosingPairs": [
         ["{", "}"],
         ["[", "]"],

src/RedConfiguration.ts

@@ -1,6 +1,6 @@
 'use strict';
 
-import { workspace, WorkspaceConfiguration } from 'vscode';
+import { window, workspace, WorkspaceConfiguration } from 'vscode';
 import * as path from 'path';
 import * as fs from 'fs';
 
@@ -16,42 +16,134 @@ function folderExists(path: fs.PathLike)
 	}
 }
 
-function checkFileExists(filePath: fs.PathLike) {
+function checkFileExists(filePath: fs.PathLike, checkExec: boolean = false) {
 	try {
-		return (fs.statSync(filePath)).isFile();
+		let isfile = fs.statSync(filePath).isFile();
+		if (!isfile) {
+			window.showErrorMessage('Cannot access file: ' + filePath);
+		}
+		if (checkExec && isfile) {
+			if (!isExec(filePath)) {
+				window.showErrorMessage('Not an executable: ' + filePath);
+				return false;
+			}
+			return true;
+		} else {
+			return isfile;
+		}
 	} catch (err) {
 		return false;
 	}
 }
 
+function isExec(p: fs.PathLike) {
+	try {
+	  fs.accessSync(p, fs.constants.X_OK);
+	  return true;
+	} catch (e) {
+	  return false;
+	}
+}
+
+function parseDate(date: string) {
+	const months = [
+		'jan', 'feb', 'mar', 'apr', 'may', 'jun',
+		'jul', 'aug', 'sep', 'oct', 'nov', 'dec'
+	];
+
+	const day = Number(date.slice(0,2));
+	const month = months.indexOf(date.slice(2,5).toLowerCase());
+	const year = Number(date.slice(5,7));
+	if (Number.isNaN(year) || Number.isNaN(day) || month === -1) {
+		return undefined;
+	}
+	return new Date(year, month, day);
+}
+
+function searchRedTool(name: string, searchPath: string) {
+	try {
+		const expectExt = process.platform === 'win32' ? '.exe' : '';
+		let files = fs.readdirSync(searchPath);
+		let tool = '';
+		let toolDate = new Date(1800, 0);
+		let startsWith = name + '-';
+		for (let f of files) {
+			let ext = path.extname(f);
+			let parts = path.basename(f, ext).slice(startsWith.length).split("-");
+			if (f.startsWith(startsWith) && parts.length === 2 && parts[0].length === 7 && ext === expectExt) {
+				let fpath = path.join(searchPath, f);
+				let date = parseDate(parts[0]);
+				let d = fs.statSync(fpath).mtime;
+				if (date !== undefined) {
+					date.setHours(d.getHours(), d.getMinutes(), d.getSeconds());
+					if (tool === '') {
+						toolDate = date;
+						tool = fpath;
+					} else {
+						if (date > toolDate) {
+							toolDate = date;
+							tool = fpath;
+						}
+					}
+				}
+			}
+		}
+		if (tool === '') {
+			tool = path.join(searchPath, name + expectExt);
+			if (!fs.statSync(tool).isFile()) {return '';};
+		}
+		return tool;
+	}
+	catch (err) {
+		return '';
+	}
+}
+
 /**
  * @param {string} exe executable name (without extension if on Windows)
  * @return {string|null} executable path if found
  * */
-function findExecutable(exe: string) {
-    const envPath = process.env.PATH || "";
+function findExecutable(exe: string, searchPath: string = '') {
+	let useOSPath = false;
+	if (searchPath === '') {
+		useOSPath = true;
+		searchPath = process.env.PATH || "";
+	}
 	let ext: string;
 	if (process.platform === 'win32') {
     	ext = ".exe";
 	} else {
 		ext = "";
 	}
-    const pathDirs = envPath
+    const pathDirs = searchPath
         .replace(/["]+/g, "")
         .split(path.delimiter)
         .filter(Boolean);
-    const candidates = pathDirs.map((d) => path.join(d, exe + ext));
-    for (let i in candidates) {	
-		if (checkFileExists(candidates[i])) {return candidates[i];};
+
+	if (useOSPath) {
+		const candidates = pathDirs.map((d) => path.join(d, exe + ext));
+		for (let i in candidates) {	
+			if (checkFileExists(candidates[i], true)) {return candidates[i];};
+		}
+	} else {
+		for (let dir of pathDirs) {
+			let tool = searchRedTool(exe, dir);
+			if (tool !== '') {
+				return checkFileExists(tool, true) ? tool : '';
+			}
+		}
 	}
 	return '';
 }
 
-function getRedConsole(gui: boolean) {
+function getRedTool(name: string, toolDir: string = '', gui: boolean = false) {
+	if (toolDir !== '') {
+		let exe = findExecutable(name, toolDir);
+		if (exe !== '') {return exe;}
+	}
+
 	if (process.platform === 'win32') {
 		// There is a `red` program on Linux already
-		let name = 'red';
-		if (gui) {name = 'red-view';}
 		let exe = findExecutable(name);
 		if (exe !== '') {return exe;}
 	}
@@ -88,8 +180,10 @@ function getRedConsole(gui: boolean) {
 				}
 			}
 		}
+		if (_console === '') {return '';}
+
 		let exe = path.join(preBuiltPath, _console);
-		return checkFileExists(exe) ? exe : '';
+		return checkFileExists(exe, true) ? exe : '';
 	}
 	catch (err) {
 		return '';
@@ -109,17 +203,32 @@ export class RedConfiguration {
 		return this.configuration.get<boolean>('red.rls-debug', false);
 	}
 
+	public get redDir(): string {
+		return this.configuration.get<string>('red.redDir', '');
+	}
+
 	public get redCore(): string {
-		return this.configuration.get<string>('red.redPath', '');
+		let exe = this.configuration.get<string>('red.redPath', '');
+		if (exe !== '' && !checkFileExists(exe, true)) {
+			return '';
+		}
+		return exe;
 	}
 
 	public get redView(): string {
-		return this.configuration.get<string>('red.redViewPath', '');
+		let exe = this.configuration.get<string>('red.redViewPath', '');
+		if (exe !== '' && !checkFileExists(exe, true)) {
+			return '';
+		}
+		return exe;
 	}
 
 	public get redToolChain(): string {
 		let path = this.configuration.get<string>('red.redToolChainPath', '');
-		return path === '' ? findExecutable("red-toolchain") : path;
+		if (path !== '' && !checkFileExists(path, true)) {
+			return '';
+		}
+		return path === '' ? findExecutable("red-toolchain", this.redDir) : path;
 	}
 
 	public get redExcludedPath(): string { 
@@ -128,12 +237,12 @@ export class RedConfiguration {
 
 	public get redConsole(): string {
 		let path = this.redCore;
-		return path === '' ? getRedConsole(false) : path; 
+		return path === '' ? getRedTool("red", this.redDir) : path; 
 	}
 
 	public get redGuiConsole(): string {
 		let path = this.redView;
-		return path === '' ? getRedConsole(true) : path;
+		return path === '' ? getRedTool("red-view", this.redDir, true) : path;
 	}
 
 	public get redWorkSpace(): string {

src/commandsProvider.ts

@@ -36,7 +36,18 @@ function normalFile(value: string): string {
 function execCommand(command: string, args: string) {
 	let text: string = "";
 
-	terminal = terminal ? terminal : vscode.window.createTerminal(`Red`);
+	for (let t of vscode.window.terminals) {
+		if (t.name === 'Red') {
+			terminal = t;
+			break;
+		}
+	}
+
+	terminal = terminal ? terminal : vscode.window.createTerminal('Red');
+	if (terminal && terminal.exitStatus) {	// killed by the user
+		terminal.dispose();
+		terminal = vscode.window.createTerminal('Red');
+	}
 	if (process.platform === 'win32') {
 		const activeTerm = vscode.window.activeTerminal;
 		if (activeTerm !== undefined && activeTerm.name !== 'bash') {
@@ -46,7 +57,7 @@ function execCommand(command: string, args: string) {
 	text = text + "\"" + command + "\"";
 	text = text + " " + args;
 	terminal.sendText(text);
-	terminal.show();
+	terminal.show(true);	// do not take the focus
 }
 
 function getFileName(fileUri?: vscode.Uri): string {
@@ -85,7 +96,7 @@ function redRunScript(gui: boolean, fileUri?: vscode.Uri) {
 		if (gui) {
 			vscode.window.showErrorMessage('No Red View! Please set the `red.redViewPath` in `settings.json`');
 		} else {
-			vscode.window.showErrorMessage('No Red Interpreter! Please set the `red.redPath` in `settings.json`');
+			vscode.window.showErrorMessage('No Red CLI! Please set the `red.redPath` in `settings.json`');
 		}
 		return;
 	}

src/extension.ts

@@ -23,7 +23,7 @@ export function activate(context: vscode.ExtensionContext) {
 	context.subscriptions.push(vscode.commands.registerCommand("red.update", () => cmds.redCompileUpdate()));
 	context.subscriptions.push(vscode.commands.registerCommand("red.commandMenu", cmds.setCommandMenu));
 	console.log("isIntelligence", config.isIntelligence);
-	if (!config.isIntelligence) {return;}
+	if (!config.isIntelligence || config.redConsole === '') {return;}
 
 	console.log("Red console path: ", config.redConsole);
 	let serverModule = path.join(context.asAbsolutePath("."), "server", "server.red");