Rename task and add defaults

Author: rnc

deploy/tasks/push-results.yaml

@@ -41,9 +41,11 @@ spec:
       default: ""
     - name: BUILD_ID
       type: string
+      default: ""
     - name: BIFROST_URL
       description: bifrost url to upload log
       type: string
+      default: ""
     - name: PNC_KONFLUX_TOOLING_IMAGE
       description: Name of the tooling image.
       type: string

pkg/reconciler/dependencybuild/buildrecipeyaml.go

@@ -31,7 +31,7 @@ const (
 	PreBuildGitTaskName = "pre-build-git"
 	BuildTaskName       = "build"
 	PostBuildTaskName   = "post-build"
-	DeployTaskName      = "deploy"
+	UploadTaskName      = "upload-artifacts"
 
 	DomainProxyImage       = "quay.io/redhat-user-workloads/konflux-jbs-pnc-tenant/domain-proxy:latest"
 	PNCKonfluxToolingImage = "quay.io/redhat-user-workloads/konflux-jbs-pnc-tenant/konflux-tooling:latest"
@@ -83,7 +83,7 @@ func createDeployPipelineSpec(jbsConfig *v1alpha1.JBSConfig, buildRequestProcess
 		Params: []tektonpipeline.ParamSpec{{Name: PipelineResultImageDigest, Type: tektonpipeline.ParamTypeString}},
 		Tasks: []tektonpipeline.PipelineTask{
 			{
-				Name: DeployTaskName,
+				Name: UploadTaskName,
 				TaskRef: &tektonpipeline.TaskRef{
 					// Can't specify name and resolver as they clash.
 					ResolverRef: resolver,
@@ -730,7 +730,7 @@ use-archive oci:$URL@$AARCHIVE=%s`, orasOptions, registryArgsWithDefaults(jbsCon
 	}
 	ps.Tasks = append([]tektonpipeline.PipelineTask{
 		{
-			Name:     DeployTaskName,
+			Name:     UploadTaskName,
 			RunAfter: append(runAfterBuild, PostBuildTaskName),
 			// Don't need to specify WorkspacePipelineTaskBinding as the deploy task is using
 			// an independent volume.

pkg/reconciler/dependencybuild/dependencybuild.go

@@ -626,7 +626,7 @@ func (r *ReconcileDependencyBuild) handleStateBuilding(ctx context.Context, db *
 
 	trueBool := true
 	pr.Spec.TaskRunSpecs = []tektonpipeline.PipelineTaskRunSpec{{
-		PipelineTaskName: DeployTaskName,
+		PipelineTaskName: UploadTaskName,
 		PodTemplate: &pod.Template{
 			Env: []v1.EnvVar{
 				{
@@ -1452,11 +1452,11 @@ func (r *ReconcileDependencyBuild) handleStateDeploying(ctx context.Context, db
 		}
 	}
 	if jbsConfig.Annotations != nil && jbsConfig.Annotations[jbsconfig.CITests] == "true" {
-		log.Info(fmt.Sprintf("Configuring resources for %#v", DeployTaskName))
+		log.Info(fmt.Sprintf("Configuring resources for %#v", UploadTaskName))
 		podMem, _ := resource.ParseQuantity("1024Mi")
 		podCPU, _ := resource.ParseQuantity("250m")
 		pr.Spec.TaskRunSpecs = []tektonpipeline.PipelineTaskRunSpec{{
-			PipelineTaskName: DeployTaskName,
+			PipelineTaskName: UploadTaskName,
 			ComputeResources: &v1.ResourceRequirements{
 				Requests: v1.ResourceList{"memory": podMem, "cpu": podCPU},
 				Limits:   v1.ResourceList{"memory": podMem, "cpu": podCPU},