Skip to content

Commit 610262a

Browse files
authored
Merge pull request #2330 from sswguo/oidc_parameters
Configure the client account information as parameters
2 parents ec02b3f + 45d225c commit 610262a

File tree

3 files changed

+26
-8
lines changed

3 files changed

+26
-8
lines changed

deploy/pipeline/mw-pipeline-v0.1.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,10 @@ spec:
4141
type: string
4242
- name: ENABLE_INDY_PROXY
4343
type: string
44+
- name: INDY_PROXY_CLIENT_ID
45+
type: string
46+
- name: INDY_PROXY_CLIENT_CREDENTIAL
47+
type: string
4448
- name: JVM_BUILD_SERVICE_REQPROCESSOR_IMAGE
4549
type: string
4650
- name: NOTIFICATION_CONTEXT
@@ -125,6 +129,10 @@ spec:
125129
value: $(params.caTrustConfigMapName)
126130
- name: ENABLE_INDY_PROXY
127131
value: $(params.ENABLE_INDY_PROXY)
132+
- name: INDY_PROXY_CLIENT_ID
133+
value: $(params.INDY_PROXY_CLIENT_ID)
134+
- name: INDY_PROXY_CLIENT_CREDENTIAL
135+
value: $(params.INDY_PROXY_CLIENT_CREDENTIAL)
128136
- name: BUILD_ARGS #TODO this should be baked in the OCI source image only a ACCESS_TOKEN should be passed
129137
value:
130138
- PROXY_URL=$(params.MVN_REPO_DEPENDENCIES_URL)

deploy/tasks/README.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,18 +12,18 @@ It should be base-lined to the most recent definition from Konflux build-definit
1212
### Domain Proxy
1313
Adds Domain Proxy to the build:
1414
* https://github.com/redhat-appstudio/jvm-build-service/blob/main/deploy/tasks/buildah-oci-ta.yaml#L134-L189
15-
* https://github.com/redhat-appstudio/jvm-build-service/blob/main/deploy/tasks/buildah-oci-ta.yaml#L288-L313
16-
* https://github.com/redhat-appstudio/jvm-build-service/blob/main/deploy/tasks/buildah-oci-ta.yaml#L327
17-
* https://github.com/redhat-appstudio/jvm-build-service/blob/main/deploy/tasks/buildah-oci-ta.yaml#L621-L657
15+
* https://github.com/redhat-appstudio/jvm-build-service/blob/main/deploy/tasks/buildah-oci-ta.yaml#L296-L321
16+
* https://github.com/redhat-appstudio/jvm-build-service/blob/main/deploy/tasks/buildah-oci-ta.yaml#L335
17+
* https://github.com/redhat-appstudio/jvm-build-service/blob/main/deploy/tasks/buildah-oci-ta.yaml#L629-L665
1818

1919
### Indy Sidecar
2020
Adds Indy configuration to the build:
21-
* https://github.com/redhat-appstudio/jvm-build-service/blob/main/deploy/tasks/buildah-oci-ta.yaml#L190-L193
22-
* https://github.com/redhat-appstudio/jvm-build-service/blob/main/deploy/tasks/buildah-oci-ta.yaml#L226-L236
23-
* https://github.com/redhat-appstudio/jvm-build-service/blob/main/deploy/tasks/buildah-oci-ta.yaml#L864-L884
21+
* https://github.com/redhat-appstudio/jvm-build-service/blob/main/deploy/tasks/buildah-oci-ta.yaml#L190-L201
22+
* https://github.com/redhat-appstudio/jvm-build-service/blob/main/deploy/tasks/buildah-oci-ta.yaml#L234-L244
23+
* https://github.com/redhat-appstudio/jvm-build-service/blob/main/deploy/tasks/buildah-oci-ta.yaml#L872-L894
2424

2525

2626
### Trusted CA
2727
Adds the trusted ca to the build:
28-
* https://github.com/redhat-appstudio/jvm-build-service/blob/main/deploy/tasks/buildah-oci-ta.yaml#L591-L595
28+
* https://github.com/redhat-appstudio/jvm-build-service/blob/main/deploy/tasks/buildah-oci-ta.yaml#L599-L603
2929

deploy/tasks/buildah-oci-ta.yaml

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,14 @@ spec:
191191
type: string
192192
description: Enable the indy generic proxy (true/false)
193193
default: "false"
194+
- name: INDY_PROXY_CLIENT_ID
195+
type: string
196+
description: The client ID used by indy proxy to communicate with Indy.
197+
default: ""
198+
- name: INDY_PROXY_CLIENT_CREDENTIAL
199+
type: string
200+
description: The client credential used by indy proxy to communicate with Indy.
201+
default: ""
194202
results:
195203
- name: IMAGE_DIGEST
196204
description: Digest of the image just built
@@ -880,5 +888,7 @@ spec:
880888
memory: 512Mi
881889
script: |
882890
if [ "$(params.ENABLE_INDY_PROXY)" == "true" ]; then
883-
/usr/local/bin/dumb-init /deployment/start-service.sh
891+
export QUARKUS_OIDC_CLIENT_CLIENT_ID="$(params.INDY_PROXY_CLIENT_ID)"
892+
export QUARKUS_OIDC_CLIENT_CREDENTIALS_SECRET="$(params.INDY_PROXY_CLIENT_CREDENTIAL)"
893+
/deployment/start-service.sh
884894
fi

0 commit comments

Comments
 (0)