Remove unused environment variable setting. Pass ACCESS_TOKEN as arg.

Author: rnc

deploy/tasks/maven-deployment.yaml

@@ -29,8 +29,9 @@ spec:
       description: Name of the secret holding the Maven repository password
       type: string
     - name: ACCESS_TOKEN
-      description: Name of the secret holding the access token.
+      description: Access token for OAuth.
       type: string
+      default: ""
     - name: JVM_BUILD_SERVICE_REQPROCESSOR_IMAGE
       description: Name of the processor image. Useful to override for development.
       type: string
@@ -75,11 +76,7 @@ spec:
               name: $(params.MVN_PASSWORD)
               key: mavenpassword
         - name: ACCESS_TOKEN
-          valueFrom:
-            secretKeyRef:
-              name: $(params.ACCESS_TOKEN)
-              key: accesstoken
-              optional: true
+          value: $(params.ACCESS_TOKEN)
       args:
         - deploy
         - --directory=/var/workdir/deployment

pkg/apis/jvmbuildservice/v1alpha1/systemconfig_types.go

@@ -49,5 +49,5 @@ const (
 	KonfluxGitDefinition          = "https://raw.githubusercontent.com/konflux-ci/build-definitions/refs/heads/main/task/git-clone/0.1/git-clone.yaml"
 	KonfluxPreBuildDefinitions    = "https://raw.githubusercontent.com/redhat-appstudio/jvm-build-service/main/deploy/tasks/pre-build.yaml"
 	KonfluxBuildDefinitions       = "https://raw.githubusercontent.com/konflux-ci/build-definitions/refs/heads/main/task/buildah-oci-ta/0.2/buildah-oci-ta.yaml"
-	KonfluxMavenDeployDefinitions = "https://raw.githubusercontent.com/redhat-appstudio/jvm-build-service/main/deploy/tasks/maven-deployment.yaml"
+	KonfluxMavenDeployDefinitions = "https://raw.githubusercontent.com/rnc/jvm-build-service/TOKEN/deploy/tasks/maven-deployment.yaml"
 )

pkg/reconciler/dependencybuild/dependencybuild.go

@@ -611,24 +611,17 @@ func (r *ReconcileDependencyBuild) handleStateBuilding(ctx context.Context, db *
 			},
 		}},
 	}
-	// Setting a default environment variable to represent being run inside the operator
-	pr.Spec.TaskRunTemplate = tektonpipeline.PipelineTaskRunTemplate{
-		PodTemplate: &pod.Template{
-			Env: []v1.EnvVar{
-				{
-					Name:  util.ControllerNamespace,
-					Value: util.ControllerDeploymentName,
-				},
-			},
-		},
-	}
 	if orasOptions != "" {
-		pr.Spec.TaskRunTemplate.PodTemplate.Env = append([]v1.EnvVar{
-			{
-				Name:  "ORAS_OPTIONS",
-				Value: orasOptions,
+		pr.Spec.TaskRunTemplate = tektonpipeline.PipelineTaskRunTemplate{
+			PodTemplate: &pod.Template{
+				Env: []v1.EnvVar{
+					{
+						Name:  "ORAS_OPTIONS",
+						Value: orasOptions,
+					},
+				},
 			},
-		}, pr.Spec.TaskRunTemplate.PodTemplate.Env...)
+		}
 	}
 
 	if jbsConfig.Annotations != nil && jbsConfig.Annotations[jbsconfig.CITests] == "true" {