Skip to content

Commit 95b284b

Browse files
committed
Move servers block to deployment step
1 parent 580760c commit 95b284b

File tree

3 files changed

+37
-19
lines changed

3 files changed

+37
-19
lines changed

deploy/tasks/maven-deployment.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,4 +84,3 @@ spec:
8484
- --mvn-repo=$(params.MVN_REPO)
8585
- --mvn-username=$(params.MVN_USERNAME)
8686
- --server-id=$(params.MVN_SERVER_ID)
87-
# - --mvn-settings=/var/workdir/settings/settings.xml

java-components/build-request-processor/src/main/java/com/redhat/hacbs/container/build/preprocessor/AbstractPreprocessor.java

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -278,24 +278,7 @@ private String getMavenSetup() {
278278
</activeProfiles>
279279
280280
<interactiveMode>false</interactiveMode>
281-
<!--
282-
Needed for Maven 3.9+. Switched to native resolver
283-
https://maven.apache.org/guides/mini/guide-resolver-transport.html
284-
-->
285-
<servers>
286-
<server>
287-
<id>indy-mvn</id>
288-
<configuration>
289-
<connectionTimeout>60000</connectionTimeout>
290-
<httpHeaders>
291-
<property>
292-
<name>Authorization</name>
293-
<value>Bearer ${ACCESS_TOKEN}</value>
294-
</property>
295-
</httpHeaders>
296-
</configuration>
297-
</server>
298-
</servers>
281+
299282
<proxies>
300283
<proxy>
301284
<id>indy-http</id>

java-components/build-request-processor/src/main/java/com/redhat/hacbs/container/deploy/DeployCommand.java

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import static org.apache.commons.lang3.ObjectUtils.isNotEmpty;
44

5+
import java.nio.file.Files;
56
import java.nio.file.Path;
67
import java.util.Optional;
78

@@ -25,6 +26,9 @@ public class DeployCommand implements Runnable {
2526
@CommandLine.Option(names = "--mvn-username")
2627
String mvnUser;
2728

29+
@ConfigProperty(name = "access.token")
30+
Optional<String> accessToken;
31+
2832
@ConfigProperty(name = "maven.password")
2933
Optional<String> mvnPassword;
3034

@@ -55,6 +59,38 @@ public void run() {
5559
}
5660
System.setProperty("maven.settings", mvnSettings);
5761
}
62+
if (isNotEmpty(accessToken)) {
63+
String servers = """
64+
<settings>
65+
<!--
66+
Needed for Maven 3.9+. Switched to native resolver
67+
https://maven.apache.org/guides/mini/guide-resolver-transport.html
68+
-->
69+
<servers>
70+
<server>
71+
<id>indy-mvn</id>
72+
<configuration>
73+
<connectionTimeout>60000</connectionTimeout>
74+
<httpHeaders>
75+
<property>
76+
<name>Authorization</name>
77+
<value>Bearer ${ACCESS_TOKEN}</value>
78+
</property>
79+
</httpHeaders>
80+
</configuration>
81+
</server>
82+
</servers>
83+
</settings>
84+
""";
85+
if (isNotEmpty(mvnSettings)) {
86+
// TODO: Would need to merge the two files. NYI for now as I don't think we need this pattern
87+
throw new RuntimeException("Merging settings.xml not supported");
88+
} else {
89+
Path settings = Path.of(deploymentPath.getParent().toString(), "settings.xml");
90+
Files.write(settings, servers.getBytes());
91+
System.setProperty("maven.settings", settings.toString());
92+
}
93+
}
5894
if (isNotEmpty(mvnRepo)) {
5995
// Maven Repo Deployment
6096
MavenRepositoryDeployer deployer = new MavenRepositoryDeployer(mvnCtx, mvnUser, mvnPassword.orElse(""), mvnRepo, serverId, deploymentPath);

0 commit comments

Comments
 (0)