Skip to content

Commit a3636d5

Browse files
authored
Merge pull request #2232 from rnc/BR2
Remove duplicate definition
2 parents ba96e95 + ebe6a78 commit a3636d5

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

openshift-with-appstudio-test/e2e/const.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,4 @@ const (
55
maxNameLength = 63
66
randomLength = 5
77
maxGeneratedNameLength = maxNameLength - randomLength
8-
gitCloneTaskUrl = "https://raw.githubusercontent.com/konflux-ci/build-definitions/main/task/git-clone/0.1/git-clone.yaml"
98
)

openshift-with-appstudio-test/e2e/util.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ func commonSetup(t *testing.T, gitCloneUrl string, namespace string) *testArgs {
180180
var ok bool
181181
ta.gitClone, ok = obj.(*tektonpipeline.Task)
182182
if !ok {
183-
debugAndFailTest(ta, fmt.Sprintf("%s did not produce a task: %#v", gitCloneTaskUrl, obj))
183+
debugAndFailTest(ta, fmt.Sprintf("%s did not produce a task: %#v", v1alpha1.KonfluxGitDefinition, obj))
184184
}
185185
ta.gitClone, err = tektonClient.TektonV1().Tasks(ta.ns).Create(context.TODO(), ta.gitClone, metav1.CreateOptions{})
186186
if err != nil {
@@ -244,7 +244,7 @@ func commonSetup(t *testing.T, gitCloneUrl string, namespace string) *testArgs {
244244
return ta
245245
}
246246
func setupE2E(t *testing.T, namespace string) *testArgs {
247-
ta := commonSetup(t, gitCloneTaskUrl, namespace)
247+
ta := commonSetup(t, v1alpha1.KonfluxGitDefinition, namespace)
248248
err := wait.PollUntilContextTimeout(context.TODO(), 1*time.Second, 1*time.Minute, true, func(ctx context.Context) (done bool, err error) {
249249
_, err = kubeClient.CoreV1().ServiceAccounts(ta.ns).Get(context.TODO(), "pipeline", metav1.GetOptions{})
250250
if err != nil {
@@ -993,7 +993,7 @@ type MavenRepoDetails struct {
993993

994994
func setupMinikube(t *testing.T, namespace string) *testArgs {
995995

996-
ta := commonSetup(t, gitCloneTaskUrl, namespace)
996+
ta := commonSetup(t, v1alpha1.KonfluxGitDefinition, namespace)
997997
//go through and limit all deployments
998998
//we have very little memory, we need some limits to make sure minikube can actually run
999999
//limit every deployment to 100mb

0 commit comments

Comments
 (0)