Improve diagnostics

Author: rnc

java-components/build-request-processor/src/main/java/com/redhat/hacbs/container/deploy/mavenrepository/MavenRepositoryDeployer.java

@@ -12,6 +12,7 @@
 import java.util.List;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
+import java.util.stream.Collectors;
 
 import org.eclipse.aether.RepositorySystem;
 import org.eclipse.aether.RepositorySystemSession;
@@ -122,9 +123,9 @@ public FileVisitResult preVisitDirectory(Path dir, BasicFileAttributes attrs)
                                     throw new RuntimeException(e);
                                 }
                             } else {
-                                if (files.stream().anyMatch(p -> !p.toFile().isDirectory())) {
-                                    Log.warnf("For directory %s, no pom file found with files %s", dir,
-                                            files);
+                                var filtered = files.stream().filter(f -> !f.toFile().isDirectory()).toList();
+                                if (!filtered.isEmpty()) {
+                                    Log.warnf("For directory %s, no pom file found with files %s", dir, filtered);
                                 }
                             }
 

java-components/build-request-processor/src/test/java/com/redhat/hacbs/container/deploy/MavenDeployTest.java

@@ -69,6 +69,8 @@ public void testDeploy() throws IOException {
 
         deployCommand.run();
         List<LogRecord> logRecords = LogCollectingTestResource.current().getRecords();
+
+        assertTrue(logRecords.stream().anyMatch(r -> LogCollectingTestResource.format(r).contains("no pom file found with files")));
         assertTrue(logRecords.stream().anyMatch(r -> LogCollectingTestResource.format(r)
                 .contains("Deploying [com.company.foo:foo-baz:pom:3.25.8]")));
         assertTrue(logRecords.stream().anyMatch(r -> LogCollectingTestResource.format(r)
@@ -86,6 +88,8 @@ private Path createDeploymentRepo()
         Path artifacts = Paths.get(testData.toString(), "artifacts").toAbsolutePath();
         Files.createDirectories(artifacts);
 
+        Files.createFile(Paths.get(artifacts.toString(), "test-file.txt"));
+
         // Add data to artifacts folder
         for (Map.Entry<String, Set<String>> artifactFiles : ARTIFACT_FILE_MAP.entrySet()) {
             String groupPath = GROUP.replace(DOT, File.separator);